Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e89e84d6da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| readability-simplify-boolean-expr, | ||
| readability-static-accessed-through-instance | ||
| WarningsAsErrors: '' | ||
| HeaderFilterRegex: '^(include|src|tests)/.*' |
There was a problem hiding this comment.
With the documented workflow clang-tidy src/database.cc -p build, this anchored relative regex does not match included headers such as /workspace/sqlite-reflection/include/database.h; clang-tidy's help says --header-filter controls diagnostics from headers while main-file diagnostics are always displayed, and a local check with this exact pattern suppressed warnings in include/... as non-user code. Since much of this library's API and templates live in headers, linting changed .cc files will silently miss header diagnostics unless this is widened, e.g. to .*(/|^)(include|src|tests)/.* or an unanchored project path pattern.
Useful? React with 👍 / 👎.
1 participant
Fixes #5