Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/core/src/config-helpers.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { describe, expect, it } from "vitest";
import { withDefaults } from "./config-helpers";

describe("withDefaults", () => {
it("defaults callbacks to an empty object when omitted", () => {
const result = withDefaults({});
expect(result.callbacks).toEqual({});
});

it("preserves user-provided callbacks", () => {
const getUser = async () => undefined;
const result = withDefaults({ callbacks: { getUser } });
expect(result.callbacks.getUser).toBe(getUser);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/config-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export type NextlyticsConfigWithDefaults = Required<
> &
NextlyticsConfig & {
anonymousUsers: Required<NonNullable<NextlyticsConfig["anonymousUsers"]>>;
callbacks: NonNullable<NextlyticsConfig["callbacks"]>;
};

export function withDefaults(config: NextlyticsConfig): NextlyticsConfigWithDefaults {
Expand All @@ -14,6 +15,7 @@ export function withDefaults(config: NextlyticsConfig): NextlyticsConfigWithDefa
eventEndpoint: config.eventEndpoint ?? "/api/event",
isApiPath: config.isApiPath ?? ((str: string) => str.startsWith("/api")),
backends: config.backends ?? [],
callbacks: config.callbacks ?? {},
anonymousUsers: {
gdprMode: config.anonymousUsers?.gdprMode ?? true,
useCookies: config.anonymousUsers?.useCookies ?? false,
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/server.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,9 @@ export function Nextlytics(userConfig: NextlyticsConfig): NextlyticsResult {
if (!ctx) {
// x-nl-page-render-id absent → check if middleware is at least active
if (!headersList.get(headerNames.active)) {
console.warn("[Nextlytics] nextlyticsMiddleware should be added in order for Server to work");
console.warn(
"[Nextlytics] nextlyticsMiddleware should be added in order for Server to work"
);
}
return <>{children}</>;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export type NextlyticsConfig = {
isApiPath?: (path: string) => boolean;
/** Endpoint for client events. Default: "/api/event" */
eventEndpoint?: string;
callbacks: {
callbacks?: {
/** Resolve authenticated user from request context */
getUser?: (ctx: RequestContext) => Promise<UserContext | undefined>;
/** Override anonymous user ID generation */
Expand Down
Loading