Please consider the following formatting changes to #13989 #170
Annotations
10 errors and 2 notices
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L74
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L476
Specified task name lf-lambdaTwoPartPolarization produces device name lf-lambda-two-part-polarization which does not match the device name lambda-two-part-polarization from the struct name lambdaTwoPartPolarization. (Matching struct name LfLambdaTwoPartPolarization)
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L389
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L449
Use constant references for non-modified iterators in range-based for loops.
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L420
Use constant references for non-modified iterators in range-based for loops.
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L317
Use constant references for non-modified iterators in range-based for loops.
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L277
Use constant references for non-modified iterators in range-based for loops.
|
|
Run tests:
PWGLF/Tasks/Strangeness/lambdaTwoPartPolarization.cxx#L43
Do not use the TLorentzVector legacy class. Use std::array with RecoDecay methods or the ROOT::Math::LorentzVector template instead.
|
|
Run tests
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
Run tests
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|
Loading