Skip to content

Please consider the following formatting changes to #13297 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jikim1290 merged 1 commit into from
Oct 9, 2025
Merged

Please consider the following formatting changes to #13297 #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Provide mandatory file documentation.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -9,7 +9,7 @@
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.
/// \author Maxim Virta (maxim.virta@cern.ch)
/// \since Jul 2024

Check failure on line 12 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \author is missing, incorrect or misplaced.

Check failure on line 12 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \brief is missing, incorrect or misplaced.

Check failure on line 12 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \file is missing, incorrect or misplaced.

#include "FlowJHistManager.h"

Expand Down Expand Up @@ -39,7 +39,7 @@

struct jEPFlowAnalysis {

HistogramRegistry EPFlowHistograms{"EPFlow", {}, OutputObjHandlingPolicy::AnalysisObject, true, true};

Check failure on line 42 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/function-variable] 

Use lowerCamelCase for names of functions and variables.
EventPlaneHelper helperEP;
FlowJHistManager histManager;
bool debug = kFALSE;
Expand Down Expand Up @@ -82,7 +82,7 @@
std::string fullCCDBShiftCorrPath;

template <typename T>
int GetdetId(const T& name)

Check failure on line 85 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/function-variable] 

Use lowerCamelCase for names of functions and variables.
{
if (name.value == "FT0C") {
return 0;
Expand Down Expand Up @@ -142,7 +142,7 @@
currentRunNumber = bc.runNumber();
if (currentRunNumber != lastRunNumber) {
shiftprofile.clear();
for (int i = 2; i < 5; i++) {

Check failure on line 145 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fullCCDBShiftCorrPath = cfgShiftPath;
fullCCDBShiftCorrPath += "/v";
fullCCDBShiftCorrPath += std::to_string(i);
Expand All @@ -153,7 +153,7 @@
}
}

for (int i = 0; i < cfgnMode; i++) { // loop over different harmonic orders
for (int i = 0; i < cfgnMode; i++) { // loop over different harmonic orders
harmInd = cfgnTotalSystem * 4 * (i) + 3; // harmonic index to access corresponding Q-vector as all Q-vectors are in same vector
eps[0] = helperEP.GetEventPlane(coll.qvecRe()[detId + harmInd], coll.qvecIm()[detId + harmInd], i + 2);
eps[1] = helperEP.GetEventPlane(coll.qvecRe()[refAId + harmInd], coll.qvecIm()[refAId + harmInd], i + 2);
Expand All @@ -166,7 +166,7 @@
float weight = 1.0;

if (cfgShiftCorr) {
for (int ishift = 1; ishift <= 10; ishift++) {

Check failure on line 169 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
auto coeffshiftxDet = shiftprofile.at(i)->GetBinContent(shiftprofile.at(i)->FindBin(cent, 0.5, ishift - 0.5));
auto coeffshiftyDet = shiftprofile.at(i)->GetBinContent(shiftprofile.at(i)->FindBin(cent, 1.5, ishift - 0.5));
auto coeffshiftxRefA = shiftprofile.at(i)->GetBinContent(shiftprofile.at(i)->FindBin(cent, 2.5, ishift - 0.5));
Expand Down Expand Up @@ -200,9 +200,9 @@
EPFlowHistograms.fill(HIST("EpResRefARefB"), i + 2, cent, resDenom);

for (int j = 0; j < cfgnMode; j++) { // loop over detectors used
for (auto& track : tracks) {

Check failure on line 203 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
float vn = std::cos((i + 2) * (track.phi() - eps[j]));
float vn_sin = std::sin((i + 2) * (track.phi() - eps[j]));

Check failure on line 205 in PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/function-variable] 

Use lowerCamelCase for names of functions and variables.

EPFlowHistograms.fill(HIST("vncos"), i + 2, cent, track.pt(), vn * weight);
EPFlowHistograms.fill(HIST("vnsin"), i + 2, cent, track.pt(), vn_sin * weight);
Expand Down
Loading