NumberDecimalSeparator at Track/Album Peak/Gain#54
Merged
jherby2k merged 2 commits intojherby2k:devfrom Jan 25, 2026
Merged
Conversation
jherby2k
reviewed
Jan 22, 2026
| else | ||
| { | ||
| if (!double.TryParse(value, out var floatValue) || floatValue < 0) | ||
| if (!double.TryParse(value, System.Globalization.NumberStyles.Float, CultureInfo.InvariantCulture, out var floatValue) || floatValue < 0) |
Owner
There was a problem hiding this comment.
Can you move these System.Globalization.NumberStyles to a "using" at the top?
jherby2k
reviewed
Jan 22, 2026
Owner
There was a problem hiding this comment.
Can you put this test in AudioMetadataTests rather than a separate file? Appreciated!
jherby2k
requested changes
Jan 22, 2026
Owner
jherby2k
left a comment
There was a problem hiding this comment.
Just a couple of formatting changes but your PR looks good! Thanks a bunch for fixing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this great module!
Found a minor issue regarding the accuracy of AudioWorks.Commands 2.2.0's
Measure-AudioFile -Analyzer ReplayGainfunction related to the number decimal separator.Tested on Windows 11 with PowerShell 7.4.2; the issue only occurs when the decimal separator is not
.but e.g.,.Expected: