Support allowed_values_function field setting in ListTextHandler:expand() #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2015 15:05
Author
|
Already covered in #46, closing. |
Contributor
|
IMHO the tests are still helpful to get in |
Owner
|
Yeah, the tests here would be awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Drupal 7
expand()method inListTextHandlerexamines the values in allowed_values. If a field has anallowed_values_functionset, an incorrect list of allowed values is examined.There doesn't appear to be equivalent Drupal 8 code.
Commit f879b5e addresses this issue by drawing allowed values from an
allowed_values_function, if set.Commit 6b003c1 roughs in possible testing (untested!).