chore(flux): switch to built-in http route for flux web#1255
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe PR consolidates Flux operator HTTP routing configuration by moving the standalone HTTPRoute manifest definition into HelmRelease values under ChangesHTTP Routing Consolidation
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested Labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
--- HelmRelease: flux-system/flux-operator HTTPRoute: flux-system/flux-operator
+++ HelmRelease: flux-system/flux-operator HTTPRoute: flux-system/flux-operator
@@ -0,0 +1,21 @@
+---
+apiVersion: gateway.networking.k8s.io/v1
+kind: HTTPRoute
+metadata:
+ name: flux-operator
+ namespace: flux-system
+ labels:
+ app.kubernetes.io/name: flux-operator
+ app.kubernetes.io/instance: flux-operator
+ app.kubernetes.io/managed-by: Helm
+spec:
+ parentRefs:
+ - name: envoy-internal
+ namespace: network
+ hostnames:
+ - flux.kantai.xyz
+ rules:
+ - backendRefs:
+ - name: flux-operator
+ port: 9080
+ |
--- kubernetes/apps/flux-system/operator/ks Kustomization: flux-system/flux-operator HelmRelease: flux-system/flux-operator
+++ kubernetes/apps/flux-system/operator/ks Kustomization: flux-system/flux-operator HelmRelease: flux-system/flux-operator
@@ -38,12 +38,19 @@
authentication:
oauth2:
issuerURL: https://pid.kantai.xyz
provider: OIDC
type: OAuth2
baseURL: https://flux.kantai.xyz
+ httpRoute:
+ enabled: true
+ hostnames:
+ - flux.kantai.xyz
+ parentRefs:
+ - name: envoy-internal
+ namespace: network
valuesFrom:
- kind: Secret
name: flux-web-oidc
targetPath: web.config.authentication.oauth2.clientID
valuesKey: client-id
- kind: Secret
--- kubernetes/apps/flux-system/operator/ks Kustomization: flux-system/flux-operator HTTPRoute: flux-system/flux-web
+++ kubernetes/apps/flux-system/operator/ks Kustomization: flux-system/flux-operator HTTPRoute: flux-system/flux-web
@@ -1,24 +0,0 @@
----
-apiVersion: gateway.networking.k8s.io/v1
-kind: HTTPRoute
-metadata:
- labels:
- app.kubernetes.io/instance: flux-operator
- app.kubernetes.io/name: flux-operator
- kustomize.toolkit.fluxcd.io/name: flux-operator
- kustomize.toolkit.fluxcd.io/namespace: flux-system
- name: flux-web
- namespace: flux-system
-spec:
- hostnames:
- - flux.kantai.xyz
- parentRefs:
- - group: gateway.networking.k8s.io
- kind: Gateway
- name: envoy-internal
- namespace: network
- rules:
- - backendRefs:
- - name: flux-operator
- port: 9080
- |
Summary by CodeRabbit