Skip to content

chore(flux): switch to built-in http route for flux web#1255

Merged
jfroy merged 1 commit into
mainfrom
flux-cleanup
May 5, 2026
Merged

chore(flux): switch to built-in http route for flux web#1255
jfroy merged 1 commit into
mainfrom
flux-cleanup

Conversation

@jfroy
Copy link
Copy Markdown
Owner

@jfroy jfroy commented May 4, 2026

Summary by CodeRabbit

  • Chores
    • Updated HTTP routing configuration for the flux-operator service to streamline deployment setup.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 92dcd389-8564-4783-a37f-74d769bb075b

📥 Commits

Reviewing files that changed from the base of the PR and between 31f28eb and 323201a.

📒 Files selected for processing (3)
  • kubernetes/apps/flux-system/operator/ks/helmrelease.yaml
  • kubernetes/apps/flux-system/operator/ks/httproute.yaml
  • kubernetes/apps/flux-system/operator/ks/kustomization.yaml
💤 Files with no reviewable changes (2)
  • kubernetes/apps/flux-system/operator/ks/kustomization.yaml
  • kubernetes/apps/flux-system/operator/ks/httproute.yaml

📝 Walkthrough

Walkthrough

The PR consolidates Flux operator HTTP routing configuration by moving the standalone HTTPRoute manifest definition into HelmRelease values under web.config.httpRoute. The routing configuration (hostname flux.kantai.xyz via envoy-internal Gateway) is preserved inline, and the kustomization is updated to remove the deleted file reference.

Changes

HTTP Routing Consolidation

Layer / File(s) Summary
HelmRelease Config
kubernetes/apps/flux-system/operator/ks/helmrelease.yaml
Added values.web.config.httpRoute with enabled: true, parent reference to envoy-internal Gateway in network namespace, and hostname flux.kantai.xyz.
Manifest Removal
kubernetes/apps/flux-system/operator/ks/httproute.yaml
Deleted standalone HTTPRoute manifest for flux-web that defined routing rules for flux.kantai.xyz to flux-operator backend on port 9080.
Kustomization Cleanup
kubernetes/apps/flux-system/operator/ks/kustomization.yaml
Removed ./httproute.yaml from resources array, keeping only ./externalsecret.yaml and ./helmrelease.yaml.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested Labels

area/kubernetes

Poem

🐰 A bunny hops through configs with glee,
Consolidating routes with precision and care—
One manifest becomes values three,
No traffic lost, just cleaner air!
Envoy greets flux at kantai.xyz fair. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(flux): switch to built-in http route for flux web' accurately describes the main change: moving HTTP routing configuration from a separate HTTPRoute resource into the HelmRelease manifest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch flux-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

--- HelmRelease: flux-system/flux-operator HTTPRoute: flux-system/flux-operator

+++ HelmRelease: flux-system/flux-operator HTTPRoute: flux-system/flux-operator

@@ -0,0 +1,21 @@

+---
+apiVersion: gateway.networking.k8s.io/v1
+kind: HTTPRoute
+metadata:
+  name: flux-operator
+  namespace: flux-system
+  labels:
+    app.kubernetes.io/name: flux-operator
+    app.kubernetes.io/instance: flux-operator
+    app.kubernetes.io/managed-by: Helm
+spec:
+  parentRefs:
+  - name: envoy-internal
+    namespace: network
+  hostnames:
+  - flux.kantai.xyz
+  rules:
+  - backendRefs:
+    - name: flux-operator
+      port: 9080
+

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

--- kubernetes/apps/flux-system/operator/ks Kustomization: flux-system/flux-operator HelmRelease: flux-system/flux-operator

+++ kubernetes/apps/flux-system/operator/ks Kustomization: flux-system/flux-operator HelmRelease: flux-system/flux-operator

@@ -38,12 +38,19 @@

         authentication:
           oauth2:
             issuerURL: https://pid.kantai.xyz
             provider: OIDC
           type: OAuth2
         baseURL: https://flux.kantai.xyz
+      httpRoute:
+        enabled: true
+        hostnames:
+        - flux.kantai.xyz
+        parentRefs:
+        - name: envoy-internal
+          namespace: network
   valuesFrom:
   - kind: Secret
     name: flux-web-oidc
     targetPath: web.config.authentication.oauth2.clientID
     valuesKey: client-id
   - kind: Secret
--- kubernetes/apps/flux-system/operator/ks Kustomization: flux-system/flux-operator HTTPRoute: flux-system/flux-web

+++ kubernetes/apps/flux-system/operator/ks Kustomization: flux-system/flux-operator HTTPRoute: flux-system/flux-web

@@ -1,24 +0,0 @@

----
-apiVersion: gateway.networking.k8s.io/v1
-kind: HTTPRoute
-metadata:
-  labels:
-    app.kubernetes.io/instance: flux-operator
-    app.kubernetes.io/name: flux-operator
-    kustomize.toolkit.fluxcd.io/name: flux-operator
-    kustomize.toolkit.fluxcd.io/namespace: flux-system
-  name: flux-web
-  namespace: flux-system
-spec:
-  hostnames:
-  - flux.kantai.xyz
-  parentRefs:
-  - group: gateway.networking.k8s.io
-    kind: Gateway
-    name: envoy-internal
-    namespace: network
-  rules:
-  - backendRefs:
-    - name: flux-operator
-      port: 9080
-

@jfroy jfroy merged commit 1452c5e into main May 5, 2026
7 checks passed
@jfroy jfroy deleted the flux-cleanup branch May 5, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant