chore: cleanup labels on flux resources#1254
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR updates metadata in two Kubernetes resource manifests within the flux-system configuration. The HTTPRoute replaces labels with a Gatus endpoint monitoring annotation, while the PodMonitor removes standard Kubernetes application labels. ChangesFlux System Resource Metadata Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
--- kubernetes/apps/flux-system/instance/ks Kustomization: flux-system/flux-instance HTTPRoute: flux-system/github-webhook
+++ kubernetes/apps/flux-system/instance/ks Kustomization: flux-system/flux-instance HTTPRoute: flux-system/github-webhook
@@ -2,14 +2,12 @@
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
annotations:
gatus.home-operations.com/endpoint: 'conditions: ["[STATUS] == 404"]'
labels:
- app.kubernetes.io/name: github-webhook
- app.kubernetes.io/part-of: flux
kustomize.toolkit.fluxcd.io/name: flux-instance
kustomize.toolkit.fluxcd.io/namespace: flux-system
name: github-webhook
namespace: flux-system
spec:
hostnames:
--- kubernetes/apps/flux-system/instance/ks Kustomization: flux-system/flux-instance PodMonitor: flux-system/flux
+++ kubernetes/apps/flux-system/instance/ks Kustomization: flux-system/flux-instance PodMonitor: flux-system/flux
@@ -1,15 +1,11 @@
---
apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
labels:
- app.kubernetes.io/component: metrics
- app.kubernetes.io/instance: flux
- app.kubernetes.io/name: flux
- app.kubernetes.io/part-of: flux
kustomize.toolkit.fluxcd.io/name: flux-instance
kustomize.toolkit.fluxcd.io/namespace: flux-system
name: flux
namespace: flux-system
spec:
jobLabel: app.kubernetes.io/instance |
Summary by CodeRabbit