Add GitHub context variables to OIDC token exchange payload #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
suggested changes
Jun 25, 2025
Contributor
EyalDelarea
left a comment
EyalDelarea
left a comment
There was a problem hiding this comment.
Just a heads-up: when a user is using the JFrog CLI’s native OIDC token exchange (introduced in version 2.75.0+), this change won’t have any effect.
Your current update only applies to the manual OIDC flow.
To support the native CLI flow, we’d need to:
• Export these environment variables to the local machine, and
• Ensure the CLI itself reads and uses them during execution.
That would require a corresponding update in the CLI codebase.
But for manual exchange flow, LGTM 👍
EyalDelarea
added
improvement
github-actions
bot
removed
the
safe to test
Contributor
|
@MariaVinog , i've updated the fields. Let me know what you think |
Contributor
|
TODO -> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Depends on cli release of:
jfrog/jfrog-cli#3014