RTECO-1352 - Add e2e test for setup docker --url path#3517
Open
Edenb2131 wants to merge 1 commit into
Open
Conversation
fluxxBot
added
the
safe to test
Exercises the fix in jfrog-cli-artifactory that derives the docker registry host from GetArtifactoryUrl() instead of the empty GetUrl(). Before the fix, `jf setup docker --url ...` called `docker login ""` and produced a misleading 401 against Docker Hub. The test runs with --url + --access-token (no saved config) and asserts that the temp docker config gets an auth entry keyed by the Artifactory registry hostname. Pins jfrog-cli-artifactory to the matching fix branch via go.mod replace so CI exercises the fix end-to-end. Remove the replace once jfrog#460 lands.
Edenb2131
force-pushed
the
RTECO-1352-add-setup-docker-e2e-test
branch
from
5bc52ac to
e0070aa
Compare
fluxxBot
added
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gofmt,go vet).Summary
Companion to jfrog/jfrog-cli-artifactory#460 — adds an end-to-end test that exercises
jf setup docker --url=..., the exact failure path of RTECO-1352. Pinsjfrog-cli-artifactoryto the matching fix branch viago.modreplace so CI runs the test against the fixed code.What's tested
jf setup dockerwith--url+--user+--access-token+--repoflags (no saved server config).--url.Before the fix the command resolved to Docker Hub and returned a 401. After the fix it correctly authenticates against the JFrog registry.
go.mod replace
Pinned to
github.com/Edenb2131/jfrog-cli-artifactory@RTECO-1352-fix-setup-docker-empty-registry. Remove the replace directive before merge once jfrog/jfrog-cli-artifactory#460 lands and a release pins the version naturally.