Skip to content

Conversation

@RemiBou
Copy link
Contributor

@RemiBou RemiBou commented Jan 8, 2026

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

// MacOS binaries should be downloaded from GitHub packages, as they are signed there.
if (currentBuild.goos == 'darwin') {
uploadSignedDarwinBinaries(currentBuild.goarch,currentBuild.pkg)
if (params.RUN_DARWIN_WORKFLOW) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if RUN_DARWIN_WORKFLOW is false ? Nothing builds ?

@RemiBou RemiBou added the safe to test Approve running integration tests on a pull request label Jan 8, 2026
@RemiBou RemiBou enabled auto-merge (squash) January 8, 2026 15:29
@RemiBou RemiBou merged commit 58593f1 into master Jan 8, 2026
72 of 75 checks passed
@RemiBou RemiBou deleted the bugfix/JGC-439-skipdarwin branch January 8, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants