Skip to content

Increase timeout in deploy tests #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehl-jf merged 1 commit into from
Apr 21, 2026
Merged

Increase timeout in deploy tests #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/commands/deploy_cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package commands
import (
"context"
"errors"
"fmt"
"testing"
"time"

Expand All @@ -25,6 +26,7 @@ type deployTestCase struct {
workerKey string
workerAction string
commandArgs []string
timeout time.Duration
initWorkers []*model.WorkerDetails
patchManifest func(mf *model.Manifest)
}
Expand All @@ -34,20 +36,24 @@ func TestDeployCommand(t *testing.T) {
deployTestSpec(deployTestCase{
name: "create",
workerKey: "wk-0",
timeout: 10 * time.Second,
}),
deployTestSpec(deployTestCase{
name: "create with a version",
workerKey: "wk-0",
commandArgs: []string{"--" + model.FlagChangesVersion, "1.0.0", "--" + model.FlagChangesDescription, "Creation of test worker"},
timeout: 10 * time.Second,
}),
deployTestSpec(deployTestCase{
name: "deploy scheduled event",
workerKey: "wk-1_1",
workerAction: "SCHEDULED_EVENT",
timeout: 10 * time.Second,
}),
deployTestSpec(deployTestCase{
name: "update",
workerKey: "wk-1",
timeout: 10 * time.Second,
initWorkers: []*model.WorkerDetails{
{
Key: "wk-1",
Expand All @@ -61,6 +67,7 @@ func TestDeployCommand(t *testing.T) {
deployTestSpec(deployTestCase{
name: "update with secrets",
workerKey: "wk-3",
timeout: 10 * time.Second,
initWorkers: []*model.WorkerDetails{
{
Key: "wk-3",
Expand Down Expand Up @@ -124,6 +131,10 @@ func deployTestSpec(tc deployTestCase) infra.TestDefinition {

cmd := append([]string{infra.AppName, "deploy"}, tc.commandArgs...)

if tc.timeout > 0 {
cmd = append(cmd, "--"+model.FlagTimeout, fmt.Sprintf("%d", tc.timeout.Milliseconds()))
}

err = it.RunCommand(cmd...)

if err == nil {
Expand Down
Loading