Added logic for fat manifest file#452
Merged
naveenku-jfrog merged 3 commits intoMay 27, 2026
Merged
Conversation
naveenku-jfrog
requested review from
a team,
agrasth,
bhanurp,
fluxxBot,
itsmeleela and
udaykb2
naveenku-jfrog
added
the
safe to test
github-actions
Bot
removed
the
safe to test
4 tasks
naveenku-jfrog
added
the
safe to test
github-actions
Bot
removed
the
safe to test
fluxxBot
requested changes
May 20, 2026
| // part of a multi-platform image: the fat manifest result item itself, plus all | ||
| // layers belonging to each platform-specific manifest digest. Layers shared | ||
| // across platforms are returned once. | ||
| func aggregateFatManifestLayers(fatManifestResult *utils.ResultItem, fatManifest *FatManifest, multiPlatformImages map[string][]*utils.ResultItem) []utils.ResultItem { |
Collaborator
There was a problem hiding this comment.
I think there's already a common method for this, can you make use of that? you might find it as part of the docker build workflow
Collaborator
Author
There was a problem hiding this comment.
I did look at createMultiPlatformBuildInfo in buildinfo.go — that's the closest existing logic for fat-manifest layer aggregation in the docker build workflow. However, it can't be reused as-is from the detailed-summary path because it does more than just aggregate layers:
- It mutates builder.imageLayers as a side-effect on the build-info builder.
- It constructs per-platform buildinfo.Module artifacts and a *buildinfo.BuildInfo return value.
- It calls setBuildProperties to write build properties back to Artifactory.
The detailed-summary flow only needs the layer list (no builder, no build-info, no prop writes), so calling it directly would pull in unwanted side-effects and the wrong return type.
fluxxBot
requested changes
May 20, 2026
naveenku-jfrog
added
the
safe to test
github-actions
Bot
removed
the
safe to test
naveenku-jfrog
force-pushed
the
RTECO-1054-Support-the-detailed-summary-flag-in-jf-docker-push-for-fat-manifest
branch
from
631d917 to
75279bd
Compare
fluxxBot
requested changes
May 27, 2026
…-in-jf-docker-push-for-fat-manifest
fluxxBot
approved these changes
May 27, 2026
naveenku-jfrog
added
the
safe to test
github-actions
Bot
removed
the
safe to test
reshmifrog
approved these changes
May 27, 2026
naveenku-jfrog
deleted the
RTECO-1054-Support-the-detailed-summary-flag-in-jf-docker-push-for-fat-manifest
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Added logic for fat manifest file