Support PNPM Auto Fix#1296
Open
orto17 wants to merge 7 commits intojfrog:v3_erfrom
Open
Conversation
github-actions
Bot
removed
the
safe to test
github-actions
Bot
removed
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
reviewed
May 7, 2026
Comment on lines
+25
to
+30
| var pnpmInstallEnvVars = map[string]string{ | ||
| pnpmFrozenLockfileEnv: "false", | ||
| configLevelEnv: "error", | ||
| ciEnv: "true", | ||
| "COREPACK_INTEGRITY_KEYS": "0", | ||
| } |
Contributor
There was a problem hiding this comment.
Please add comments on why it exists
Comment on lines
+121
to
+124
| func (cph *CommonPackageUpdater) EscapeJSONPathKey(key string) string { | ||
| r := strings.NewReplacer(".", "\\.", "*", "\\*", "?", "\\?") | ||
| return r.Replace(key) | ||
| } |
Contributor
There was a problem hiding this comment.
why is this a class func? can be static
Comment on lines
+184
to
+186
| func escapeJsonPathKey(key string) string { | ||
| var c CommonPackageUpdater | ||
| return c.EscapeJSONPathKey(key) |
Contributor
There was a problem hiding this comment.
no need for that, move func to be unrelated to class and use it
| } | ||
|
|
||
| // envWithCorepackIntegrityWorkaround sets COREPACK_INTEGRITY_KEYS=0 for older Node/Corepack (e.g. corepack#612). | ||
| func envWithCorepackIntegrityWorkaround(base []string) []string { |
Contributor
There was a problem hiding this comment.
we use it with envWithCorepackIntegrityWorkaround(os.Environ())
did you validate the code with this? do we have tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for PNPM auto-fix:
Examples for pull-requests created by the new pnpm package updater:
orto17/pnpm_example#3
orto17/pnpm_example#2