Skip to content

Optimize tests for v3 #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eyalk007 wants to merge 2 commits into
base: v3_er
Choose a base branch
from
Open

Optimize tests for v3 #1007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c06d3a
Optimize test workflow by removing unnecessary package manager instal…
eyalk007 Dec 23, 2025
0c32df9
Add Go module caching to integration tests
eyalk007 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 47 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,58 +115,66 @@ jobs:
${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}-
${{ runner.os }}-go-

# Package managers are only needed for Package Handlers tests (fix functionality)
Copy link
Contributor

@eranturgeman eranturgeman Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about integration tests that run Scan-pr and Scan-repo commands and require to perform actual upgrades and dependencies resolutions?

- name: Install npm
if: matrix.suite.package == 'packagehandlers'
uses: actions/setup-node@v3
with:
node-version: "16"

- name: Setup Python3
if: matrix.suite.package == 'packagehandlers'
uses: actions/setup-python@v4
with:
python-version: "3.x"

- name: Install python components
if: matrix.suite.package == 'packagehandlers'
run: python -m pip install pipenv poetry

- name: Install Mono on macOS
if: matrix.suite.package == 'packagehandlers' && runner.os == 'macOS'
run: brew install mono
if: runner.os == 'macOS'

- name: Install dotnet
if: matrix.suite.package == 'packagehandlers'
uses: actions/setup-dotnet@v4
with:
dotnet-version: "6.x"

- name: Install Mono on linux
if: runner.os == 'Linux'
if: matrix.suite.package == 'packagehandlers' && runner.os == 'Linux'
run: |
sudo apt-get update
sudo apt-get install -y mono-devel

- name: Install NuGet on Linux
if: matrix.suite.package == 'packagehandlers' && (runner.os == 'Linux' || runner.os == 'macOS')
uses: nuget/setup-nuget@v2
with:
nuget-version: 6.11.0
if: runner.os == 'Linux' || runner.os == 'macOS'

- uses: awalsh128/cache-apt-pkgs-action@latest
if: runner.os == 'Linux'
if: matrix.suite.package == 'packagehandlers' && runner.os == 'Linux'
with:
packages: apt-transport-https dirmngr gnupg ca-certificates
version: 1.0

- name: Install Pnpm
if: matrix.suite.package == 'packagehandlers'
uses: pnpm/action-setup@v3
with:
version: 8

- name: Install Java
if: matrix.suite.package == 'packagehandlers'
uses: actions/setup-java@v4
with:
distribution: "adopt"
java-version: "11"

- name: Install Conan
if: matrix.suite.package == 'packagehandlers'
run: |
python -m pip install conan
conan profile detect
Expand Down Expand Up @@ -204,6 +212,15 @@ jobs:
with:
go-version: 1.23.x
cache: false

- name: Go Cache Dependencies
uses: actions/cache@v4
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-

- name: Go Cache Build & Tests
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -249,6 +266,15 @@ jobs:
with:
go-version: 1.23.x
cache: false

- name: Go Cache Dependencies
uses: actions/cache@v4
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-

- name: Go Cache Build & Tests
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -294,6 +320,15 @@ jobs:
with:
go-version: 1.23.x
cache: false

- name: Go Cache Dependencies
uses: actions/cache@v4
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-

- name: Go Cache Build & Tests
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -343,6 +378,14 @@ jobs:
chmod +x $bb_script_path
sh $bb_script_path

- name: Go Cache Dependencies
uses: actions/cache@v4
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-

- name: Go Cache Build & Tests
uses: actions/cache@v4
with:
Expand Down
Loading