Conversation
…-scan Remove CodeQL pull_request trigger for develop scans
…or-installation Sync USER_AGREEMENT from wiki before build and include it in NSIS installer
…ki, converting Markdown to plain text with fallback support.
…ding setup, key management, batch operations, and auto-unlock capabilities.
…enhance user agreement synchronization.
…enhance user agreement synchronization. feat: Add NoteWizard exporter module to create .nwp packages, supporting encrypted notes and manifest generation.
Feature/1.1.4
script:update tos script
Feature/1.1.4
Issue Form
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a90eedc3c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "oneClick": false, | ||
| "perMachine": false, | ||
| "allowToChangeInstallationDirectory": true, | ||
| "license": "src/assets/terms-of-service/USER_AGREEMENT.txt", |
There was a problem hiding this comment.
The new NSIS license path points to src/assets/terms-of-service/USER_AGREEMENT.txt, but this commit only adds/syncs src/assets/terms-of-service/local-tos.txt (scripts/sync-terms-of-service.js). Because nsis.license is a custom resource path, electron-builder will try to resolve that exact file and fail packaging when it is missing, so Windows release jobs (dist:win/dist:all) will break.
Useful? React with 👍 / 👎.
| if (meta?.encrypted === true) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
hasEncryptedDataInDatabase() only short-circuits for meta.encrypted === true; when meta.encrypted is explicitly false, it still synchronously scans and reads every .md file in objects/ and trash/. Since encryption:is-enabled now calls this function and vfs.writeContent invokes encryption:is-enabled on each save/autosave, this introduces repeated O(number of notes) disk I/O in the normal unencrypted case, which can cause noticeable save-time lag on large workspaces.
Useful? React with 👍 / 👎.
1 participant
No description provided.