fix: correct field access in isFieldSubquery check and fieldMetadataSubquery lookup by Copilot · Pull Request #1644 · jetstreamapp/jetstream

Copilot · 2026-04-06T23:27:25Z

Two incorrect property accesses in data-table-utils.tsx caused subquery column metadata to be silently dropped.

Changes

isFieldSubquery index fix: results.parsedQuery?.[i] was indexing the query object as an array — corrected to results.parsedQuery?.fields?.[i] to match the actual structure used elsewhere in the file.
fieldMetadataSubquery two-level lookup: fieldMetadataSubquery?.[field] was using a flat field string against a Record<string, Record<string, Field>> structure — corrected to fieldMetadataSubquery?.[parentField.subquery.relationshipName]?.[field.toLowerCase()] to properly traverse both levels.

// Before
isSubquery: isFieldSubquery(results.parsedQuery?.[i])
fieldMetadata: fieldMetadataSubquery?.[field]

// After
isSubquery: isFieldSubquery(results.parsedQuery?.fields?.[i])
fieldMetadata: fieldMetadataSubquery?.[parentField.subquery.relationshipName]?.[field.toLowerCase()]

Original prompt

Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"The `isFieldSubquery` check is incorrectly checking `results.parsedQuery?.[i]` instead of accessing the fields array. It should be `results.parsedQuery?.fields?.[i]` to match the structure used elsewhere in the code.","fixFiles":[{"filePath":"libs/ui/src/lib/data-table/data-table-utils.tsx","diff":"diff --git a/libs/ui/src/lib/data-table/data-table-utils.tsx b/libs/ui/src/lib/data-table/data-table-utils.tsx\n--- a/libs/ui/src/lib/data-table/data-table-utils.tsx\n+++ b/libs/ui/src/lib/data-table/data-table-utils.tsx\n@@ -169,7 +169,12 @@\n \n   // Base fields\n   const parentColumns: ColumnWithFilter<RowWithKey>[] = getFlattenedFields(results.parsedQuery || {}).map((field, i) =>\n-    getQueryResultColumn({ field, queryColumnsByPath, isSubquery: isFieldSubquery(results.parsedQuery?.[i]), fieldMetadata }),\n+    getQueryResultColumn({\n+      field,\n+      queryColumnsByPath,\n+      isSubquery: isFieldSubquery(results.parsedQuery?.fields?.[i]),\n+      fieldMetadata,\n+    }),\n   );\n \n   // set checkbox as first column\n"}]},{"message":"The `fieldMetadataSubquery` lookup is using `field` (a string) directly, but `fieldMetadataSubquery` is typed as `Record<string, Record<string, Field>>`, which requires two levels of indexing. This should likely be `fieldMetadataSubquery?.[parentField.subquery.relationshipName]?.[field.toLowerCase()]` to properly access the nested structure.","fixFiles":[{"filePath":"libs/ui/src/lib/data-table/data-table-utils.tsx","diff":"diff --git a/libs/ui/src/lib/data-table/data-table-utils.tsx b/libs/ui/src/lib/data-table/data-table-utils.tsx\n--- a/libs/ui/src/lib/data-table/data-table-utils.tsx\n+++ b/libs/ui/src/lib/data-table/data-table-utils.tsx\n@@ -207,7 +207,7 @@\n           queryColumnsByPath,\n           isSubquery: false,\n           allowEdit: false,\n-          fieldMetadata: fieldMetadataSubquery?.[field],\n+          fieldMetadata: fieldMetadataSubquery?.[parentField.subquery.relationshipName]?.[field.toLowerCase()],\n         }),\n       );\n     });\n"}]}]

Copilot

Pull request overview

Fixes two incorrect property accesses in the UI data table column-definition logic that could cause subquery metadata/handling to be skipped.

Changes:

Corrected isFieldSubquery detection to index into results.parsedQuery.fields rather than the query object.
Updated subquery field metadata lookup to traverse the nested Record<string, Record<string, Field>> structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

libs/ui/src/lib/data-table/data-table-utils.tsx

Copilot · 2026-04-07T14:03:59Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

cdn.jsdelivr.net
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…a-table-utils

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-08T03:00:30Z

libs/ui/src/lib/data-table/data-table-utils.tsx

+  // Build a set of subquery relationship names for reliable lookup
+  // (positional index is unreliable because getFlattenedFields uses flatMap, e.g. TYPEOF expands to multiple entries)
+  const subqueryRelationshipNames = new Set(
+    results.parsedQuery?.fields?.filter(isFieldSubquery).map((f) => f.subquery.relationshipName) || [],
+  );
+
  // Base fields
-  const parentColumns: ColumnWithFilter<RowWithKey>[] = getFlattenedFields(results.parsedQuery || {}).map((field, i) =>
-    getQueryResultColumn({ field, queryColumnsByPath, isSubquery: isFieldSubquery(results.parsedQuery?.[i]), fieldMetadata }),
+  const parentColumns: ColumnWithFilter<RowWithKey>[] = getFlattenedFields(results.parsedQuery || {}).map((field) =>
+    getQueryResultColumn({
+      field,
+      queryColumnsByPath,
+      isSubquery: subqueryRelationshipNames.has(field),
+      fieldMetadata,
+    }),


subqueryRelationshipNames is built with relationship names as-is, and the Set.has(field) check is case-sensitive. Elsewhere in the codebase relationship names are compared case-insensitively (e.g., using .toLowerCase()), and Salesforce SOQL/metadata is generally case-insensitive. Consider normalizing both sides (store relationshipName.toLowerCase() in the set and check field.toLowerCase()) so subquery detection doesn’t fail when the query uses different casing.

libs/ui/src/lib/data-table/data-table-utils.tsx

…pping

… metadata Ensure subquery restore is not case-sensitive

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI assigned Copilot and paustint Apr 6, 2026

Copilot started work on behalf of paustint April 6, 2026 23:27 View session

Copilot AI changed the title ~~[WIP] Fix isFieldSubquery check to access fields array correctly~~ fix: correct field access in isFieldSubquery check and fieldMetadataSubquery lookup Apr 6, 2026

Copilot AI requested a review from paustint April 6, 2026 23:30

Copilot finished work on behalf of paustint April 6, 2026 23:30

paustint marked this pull request as ready for review April 7, 2026 03:25

Copilot AI review requested due to automatic review settings April 7, 2026 03:25

Copilot started reviewing on behalf of paustint April 7, 2026 03:26 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

libs/ui/src/lib/data-table/data-table-utils.tsx Outdated Show resolved Hide resolved

Copilot started work on behalf of paustint April 7, 2026 13:54 View session

Copilot finished work on behalf of paustint April 7, 2026 13:56

Copilot started work on behalf of paustint April 7, 2026 13:56 View session

Copilot finished work on behalf of paustint April 7, 2026 14:04

fix: correct isFieldSubquery and fieldMetadataSubquery lookups in dat…

fd7669a

…a-table-utils

paustint force-pushed the copilot/fix-isfieldsubquery-check branch 2 times, most recently from a1c1e05 to 88af1f5 Compare April 8, 2026 02:57

paustint requested a review from Copilot April 8, 2026 02:57

Copilot started reviewing on behalf of paustint April 8, 2026 02:57 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

paustint added 2 commits April 8, 2026 08:59

fix: improve handling of subquery fields and refactor query column ma…

f0f341f

…pping

fix: enhance subquery processing by tracking missing relationships in…

08c16a8

… metadata Ensure subquery restore is not case-sensitive

paustint force-pushed the copilot/fix-isfieldsubquery-check branch from 88af1f5 to 08c16a8 Compare April 8, 2026 16:00

paustint requested a review from Copilot April 10, 2026 15:59

Copilot started reviewing on behalf of paustint April 10, 2026 16:00 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: correct field access in isFieldSubquery check and fieldMetadataSubquery lookup#1644

fix: correct field access in isFieldSubquery check and fieldMetadataSubquery lookup#1644
Copilot wants to merge 3 commits intomainfrom
copilot/fix-isfieldsubquery-check

Copilot AI commented Apr 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI commented Apr 7, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI commented Apr 7, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 6, 2026 •

edited

Loading