fix: replace any[] with FieldValues[] and remove stale eslint-disable in CreateFieldsImportExport#1643
Open
fix: replace any[] with FieldValues[] and remove stale eslint-disable in CreateFieldsImportExport#1643
any[] with FieldValues[] and remove stale eslint-disable in CreateFieldsImportExport#1643Conversation
…isable comment in CreateFieldsImportExport Agent-Logs-Url: https://github.com/jetstreamapp/jetstream/sessions/94e44f6e-a9ea-4ade-b537-2b7be89115a6 Co-authored-by: paustint <5461649+paustint@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update any[] type to specific type in CreateFieldsImportExport
fix: replace Apr 6, 2026
any[] with FieldValues[] and remove stale eslint-disable in CreateFieldsImportExport
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets code quality in CreateFieldsImportExport.tsx by tightening a state type and removing a stale ESLint suppression around an intentionally reassigned let binding.
Changes:
- Replaced
useState<any[]>withuseState<FieldValues[]>forexportData - Removed
// eslint-disable-next-line prefer-constabovelet { data, errors } = ...inhandleImport
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0ef1c57 to
9a2aa09
Compare
…tData state and type getRowsForExport accumulator Agent-Logs-Url: https://github.com/jetstreamapp/jetstream/sessions/55106e57-f28e-450f-9874-1157f6486509 Co-authored-by: paustint <5461649+paustint@users.noreply.github.com>
9a2aa09 to
790ebe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor code quality issues in
CreateFieldsImportExport.tsx: impreciseany[]type on exported state, and a misleading eslint-disable comment on aletbinding that is intentionally reassigned.Changes
useState<any[]>→useState<FieldValues[]>—FieldValueswas already imported; the state holds the same type as therowsprop.// eslint-disable-next-line prefer-constbeforelet { data, errors }. Theletis correct sincedatais reassigned during key normalization; the comment was incorrectly suggesting otherwise.Original prompt