Skip to content

fix: limit popup panel width on large screens #5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IdrisGit wants to merge 1 commit into from
Closed

fix: limit popup panel width on large screens #5200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pkg/gui/controllers/helpers/confirmation_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,10 @@ func (self *ConfirmationHelper) getPopupPanelDimensionsAux(panelWidth int, panel

func (self *ConfirmationHelper) getPopupPanelWidth() int {
width, _ := self.c.GocuiGui().Size()
// we want a minimum width up to a point, then we do it based on ratio.
panelWidth := 4 * width / 7
minWidth := 80
if panelWidth < minWidth {
panelWidth = min(width-2, minWidth)
}
// we want a width based on commit auto-wrap plus some padding, then we cap it to terminal size when it's smaller than the desired width.
commitAutoWrapWidth := self.c.UserConfig().Git.Commit.AutoWrapWidth
desiredPanelWidth := commitAutoWrapWidth + 25
panelWidth := min(width-2, desiredPanelWidth)

return panelWidth
}
Expand Down