Skip to content
This repository was archived by the owner on Jan 25, 2022. It is now read-only.

Conversation

@rostskadat
Copy link

Hello,

There is a use case where one wants to use HTTP URLs instead of SSH base
URLs. This commit adds the use_http_urls setting and modify the
merge_request_details and payload_request_details in order to use the
new git_http_url field of the JSON payload.

There is a use case where one wants to use HTTP URLs instead of SSH base
URLs. This commit adds the use_http_urls setting and modify the
merge_request_details and payload_request_details in order to use the
new git_http_url field of the JSON payload
@javiplx
Copy link

javiplx commented Jul 23, 2018

Test are failing (see TravisCI). Would you mind to have a look? (the jruby-1.7-19mode ones are probably causing failures on acceptance tests).
If you make the pull request against https://github.com/javiplx/jenkins-gitlab-hook-plugin, travis should launch automatically

@rostskadat
Copy link
Author

@javiplx : Sorry for the late answer. I looked at the build logs and I'm a bit confused: It seems that it fails in ./models/util/settings.rb:4 saying basically undefined method `descriptor' for nil:NilClass.

  • The refered class is jenkins.model.Jenkins. For some reason the class is not instanciated.
  • I'm not really sure how to find out why the class is not properly instanicanted.

=> Could you tell me maybe how to turn debug during the tests?

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants