This repository was archived by the owner on Jan 25, 2022. It is now read-only.
Fix null pointer related to SECURITY-263 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what is the difference respect the baseline on javiplx@8e127c3 |
Author
|
@javiplx The core difference is calling Secrets.toString instead of get_plain_text. |
Author
|
I can separate out the readme updates from the crash updates if you prefer. I just figured those were minor enough. Crash only commit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a different addition to this but in trying to set up my environment I ran into this issue. Basically on a fresh install of jenkins or when installing this plugin for the first time with the SECURITY-263 fix the configure page would crash on me.
Also updated the readme to reflect some of what I experience in my setup.
Note with latest ruby there are some changes to the DIr class which affects the Spec files the most,
spec/plugins/WEB-INF/classeswould only work for me if I change it to/spec/plugins/WEB-INF/classesbut I haven't looked deeper into this.