Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
288 commits
Select commit Hold shift + click to select a range
81639d0
[JENKINS-28139] add method to extension point for parse payload of an…
Jul 11, 2015
cafc786
[JENKINS-28139] move all parsing logic from webhook root action to ex…
Jul 11, 2015
15b5e8b
[JENKINS-28139] add tests for all webhook preprocess classes
Jul 11, 2015
a88fc10
change error to warn on reregister btn
Jul 11, 2015
029f05d
make all subscriber api protected to use this api via static methods
Jul 11, 2015
0506960
add test to verify onEvent from subscriber calls trigger
Jul 11, 2015
0ed510e
don't replace every time same hook on configuration saving
Jul 11, 2015
b2f08d3
remove duplicated log event from default subscriber
Jul 11, 2015
af7867d
add mention of guava's code usage
Jul 11, 2015
948d2df
move all hook registration code to root action
Jul 11, 2015
a72162e
integration test formatting
Jul 15, 2015
3a9e6a0
Nonnull annotations
Jul 15, 2015
dc47940
Merge pull request #60 from lanwen/hook-parse
KostyaSha Jul 15, 2015
601eb56
Mention about admin:repo_hook scope for credentials
Jul 15, 2015
5d0b38b
use slf4j style template for logging in gh-webhook class
Jul 15, 2015
8eed253
Merge pull request #62 from lanwen/logging
KostyaSha Jul 15, 2015
373086f
[maven-release-plugin] prepare release github-1.12.0-alpha-1
KostyaSha Jul 18, 2015
c6a08ea
[maven-release-plugin] prepare for next development iteration
KostyaSha Jul 18, 2015
b5a89ce
handle exceptions of extensions
Jul 19, 2015
bcb51b2
Merge pull request #64 from lanwen/exc-handling
KostyaSha Jul 20, 2015
b73f1e8
[maven-release-plugin] prepare release github-1.12.0
KostyaSha Jul 22, 2015
6f1354b
[maven-release-plugin] prepare for next development iteration
KostyaSha Jul 22, 2015
389d2de
change since tag for new api introduced in 1.12.0
Jul 29, 2015
b2f2726
use Validate state instead of "if" to validate jenkins instance is no…
Jul 29, 2015
131a281
extend FluentIterableWrapper with "first()" method from guava
Jul 29, 2015
18e24ad
add null-safe predicate and function with precheck arg for null
Jul 29, 2015
33087eb
fix "Unknown content type null" in logs
Jul 29, 2015
9723aab
add checkForNull for resolveOne in GHRepoName
Jul 29, 2015
a8dc555
Merge pull request #66 from lanwen/misc
KostyaSha Jul 29, 2015
18aca71
[FIXED JENKINS-29787] Fix NPE for race condition.
KostyaSha Aug 4, 2015
cc84ef4
Merge pull request #67 from KostyaSha/fixNPE
KostyaSha Aug 10, 2015
038daba
[maven-release-plugin] prepare release github-1.12.1
KostyaSha Aug 10, 2015
a5a2f97
[maven-release-plugin] prepare for next development iteration
KostyaSha Aug 10, 2015
5aeec4f
[JENKINS-24702] add deps to migrate to credentials-plugin
lanwen Jul 31, 2015
b322d95
[JENKINS-24702] new configuration point in global github-plugin
lanwen Jul 31, 2015
456cc65
use slf4j logger in gh-push-trigger class
lanwen Jul 31, 2015
7b69cf4
use slf4j logger in gh-repo-name
lanwen Jul 31, 2015
fa7e64a
use commons-lang3 to generate hash code, to string and equals for gh-…
lanwen Jul 31, 2015
808eeaf
[JENKINS-24702] remove usage of old configs
lanwen Jul 31, 2015
c6609b8
[JENKINS-24702] add tests for new credentials usage code
lanwen Jul 31, 2015
cec7468
add help files to new credentials UI
lanwen Jul 31, 2015
2851a1d
newline at the end of help files
lanwen Aug 2, 2015
71cdab4
get help file by descriptor method call instead of string
lanwen Aug 3, 2015
758676c
make visible btn "reregister hooks" all the time, but move it to adva…
lanwen Aug 9, 2015
2176fd6
rename field "custom" to "customApiUrl"
lanwen Aug 10, 2015
bb047ff
Merge pull request #65 from lanwen/creds
KostyaSha Aug 11, 2015
242a06b
[maven-release-plugin] prepare release github-1.13.0-alpha-1
KostyaSha Aug 11, 2015
81fbf3f
[maven-release-plugin] prepare for next development iteration
KostyaSha Aug 11, 2015
2108560
use GlobalConfiguration as extension point to store all global config
lanwen Aug 12, 2015
52c7975
Merge pull request #68 from lanwen/global_conf
KostyaSha Aug 17, 2015
fbca897
[maven-release-plugin] prepare release github-1.13.0-alpha-2
KostyaSha Aug 17, 2015
909f546
[maven-release-plugin] prepare for next development iteration
KostyaSha Aug 17, 2015
9b5fba6
checkstyle with contributing guides
lanwen Aug 17, 2015
5b018be
Merge pull request #69 from lanwen/checkstyle
KostyaSha Aug 17, 2015
73fccae
Remove included page
KostyaSha Aug 17, 2015
007e9ef
unexpected npe fixes for findbugs
lanwen Aug 17, 2015
6b156f1
Merge pull request #70 from lanwen/fb
KostyaSha Aug 18, 2015
6c97489
add separate PING event subscriber
lanwen Aug 18, 2015
c7a43e4
Merge pull request #71 from lanwen/ping
KostyaSha Aug 18, 2015
134cda2
change since annotations to new release version (1.13.0)
lanwen Aug 23, 2015
2bdcf3c
Merge pull request #74 from lanwen/since
KostyaSha Aug 23, 2015
ef8496b
[maven-release-plugin] prepare release github-1.13.0
KostyaSha Aug 23, 2015
2f7f4bf
[maven-release-plugin] prepare for next development iteration
KostyaSha Aug 23, 2015
7bcf65a
[maven-release-plugin] rollback the release of github-1.13.0
KostyaSha Aug 23, 2015
ec40107
suppress checkstyle on Messages.java
lanwen Aug 23, 2015
69e88f3
Merge pull request #75 from lanwen/check_supr
KostyaSha Aug 23, 2015
88c6afc
[maven-release-plugin] prepare release github-1.13.0
KostyaSha Aug 23, 2015
8791c2a
[maven-release-plugin] prepare for next development iteration
KostyaSha Aug 23, 2015
e4f7c8e
don't run cleaner if we don't manage hooks
lanwen Aug 30, 2015
fe0c542
throw config exception on empty jenkins root url
lanwen Aug 30, 2015
80c8396
Merge pull request #77 from lanwen/JENKINS-30207_fix
KostyaSha Aug 30, 2015
b5db64c
check hook url for override before checking jenkins default url
lanwen Aug 31, 2015
a726907
Merge pull request #78 from lanwen/precheck_for_hook_url
KostyaSha Aug 31, 2015
061d849
[FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential
lanwen Aug 31, 2015
3624130
Merge pull request #79 from lanwen/restore_creds
KostyaSha Aug 31, 2015
7561722
additional request logging for form submitting
lanwen Sep 1, 2015
2d621d6
Merge pull request #80 from lanwen/req_logging
lanwen Sep 2, 2015
27f9802
[JENKINS-27136] Workflow plugin support
Jul 1, 2015
446925c
[JENKINS-27136] Add more tests for wf-stuff
lanwen Sep 3, 2015
3c56fa7
Merge pull request #82 from lanwen/wflow
lanwen Sep 3, 2015
8e58ca6
[maven-release-plugin] prepare release github-1.14.0-alpha-1
lanwen Sep 21, 2015
ab69524
[maven-release-plugin] prepare for next development iteration
lanwen Sep 21, 2015
5de4c7b
Fixed Javadoc link.
jglick Sep 22, 2015
e573a28
don't be platform specific in checkstyle.
jtnord Sep 22, 2015
60c896c
Merge pull request #85 from jglick/isApplicable-Javadoc
lanwen Sep 23, 2015
727de7d
Merge pull request #86 from jtnord/use_lf_in_checkstyle
lanwen Sep 23, 2015
942f63a
Create .gitattributes file to handle line endings
lanwen Sep 23, 2015
6b819f4
Merge pull request #87 from lanwen/gitattributes
lanwen Sep 23, 2015
03b1c87
[FIXED JENKINS-30626] Handle pings from organization webhooks
jglick Sep 23, 2015
d88889a
using okHttp connector with cache and proxy for github
lanwen Sep 23, 2015
52027be
Merge pull request #88 from lanwen/cache
lanwen Sep 26, 2015
77bcc99
[maven-release-plugin] prepare release github-1.14.0-alpha-2
lanwen Sep 26, 2015
ce32bc5
[maven-release-plugin] prepare for next development iteration
lanwen Sep 26, 2015
d4853d9
fix checking creds on github enterprise
lanwen Sep 27, 2015
7293422
Merge pull request #90 from lanwen/cached_check_enterprise
KostyaSha Sep 27, 2015
0037970
simply return on empty list of events to subscribe, without error
lanwen Sep 27, 2015
718a450
Merge pull request #91 from lanwen/empty_events
lanwen Sep 28, 2015
de96c1a
add coverage badge
lanwen Sep 28, 2015
ef8d88e
separate cache for each server config
lanwen Oct 4, 2015
abe3c9b
Merge pull request #93 from lanwen/separate_cache
KostyaSha Oct 6, 2015
8eafea8
fix dynamic port allocation when using wiremock to mock GH
lanwen Oct 7, 2015
31c377c
Merge pull request #94 from lanwen/wiremock_dynamic
lanwen Oct 7, 2015
a9e8f89
add overrides on methods in GitHubWebHook class
lanwen Oct 7, 2015
5fc9944
change since to new 1.14.0 ver
lanwen Oct 7, 2015
d9ba5b7
Merge pull request #95 from lanwen/since1140
lanwen Oct 7, 2015
5c55f50
change developers pom section to reflect current state
lanwen Oct 7, 2015
0627503
Merge pull request #96 from lanwen/authors
KostyaSha Oct 7, 2015
8bf6253
[maven-release-plugin] prepare release github-1.14.0
lanwen Oct 7, 2015
2f99129
[maven-release-plugin] prepare for next development iteration
lanwen Oct 7, 2015
a6eb704
ignore files when clean root cache dir
lanwen Oct 7, 2015
8630c49
Merge pull request #97 from lanwen/files_in_cache
lanwen Oct 7, 2015
3990a36
Let GithubProjectProperty be applied to any Job.
jglick Sep 17, 2015
e3ba807
simplify testing of GHRepoName
lanwen Oct 16, 2015
ce831f4
add new static factory for GHRepoName to create it from GHProjectProp…
lanwen Oct 16, 2015
c2d0af6
reuse validated logic of GHRepoName in default push subscriber
lanwen Oct 17, 2015
7fa4a9e
Merge pull request #98 from lanwen/reponame
lanwen Oct 18, 2015
a07e375
add functional contribution section to CONTRIB.md
lanwen Oct 18, 2015
815f733
Merge pull request #99 from lanwen/contrib
KostyaSha Oct 27, 2015
798377f
Enable FindBugs in the local build flows.
oleg-nenashev Aug 19, 2015
1ed2edd
Merge pull request #101 from jenkinsci/72-pr
lanwen Oct 27, 2015
e1383d6
expandable message to use in builders and publishers
lanwen Oct 18, 2015
b6fb807
context name field in GitHubProjectProperty to use in status builder …
lanwen Nov 18, 2015
5dfb780
remove email-ext private token support
lanwen Nov 23, 2015
9f01fd0
add custom status message and predefined context to GHCommitNotifier
lanwen Dec 3, 2015
0d4c02b
add custom status message and predefined context to GHCommit Status B…
lanwen Dec 13, 2015
a8c28c4
add since javadoc for new methods
lanwen Dec 14, 2015
8b9535d
Merge pull request #100 from lanwen/expandable
lanwen Dec 14, 2015
1ad0837
[maven-release-plugin] prepare release github-1.14.1
lanwen Dec 15, 2015
c8af6ec
[maven-release-plugin] prepare for next development iteration
lanwen Dec 15, 2015
57d7870
[FIXES JENKINS-32132] Check status message is null (in case of wrong …
lanwen Dec 20, 2015
2c193b4
Merge pull request #103 from lanwen/fix_JENKINS-32132
lanwen Dec 20, 2015
6b783df
[maven-release-plugin] prepare release github-1.14.2
lanwen Dec 20, 2015
4197fdf
[maven-release-plugin] prepare for next development iteration
lanwen Dec 20, 2015
4024d62
Test for JENKINS-32132 with rule to mock GH
lanwen Dec 21, 2015
5e14cca
Merge pull request #104 from lanwen/JENKINS-32132_tests
lanwen Dec 22, 2015
731ffae
Allow Commit Notifications to be used as Workflow Build Steps.
arthurschreiber Dec 28, 2015
4ba1dbc
Merge pull request #102 from arthurschreiber/arthur/extend-workflow-s…
lanwen Dec 31, 2015
b477fb3
[maven-release-plugin] prepare release github-1.15.0
Jan 7, 2016
2b94ad7
[maven-release-plugin] prepare for next development iteration
Jan 7, 2016
054719a
Use `TransientActionFactory` instead of `GithubProjectProperty.getJob…
arthurschreiber Jan 14, 2016
ad03690
Merge pull request #105 from arthurschreiber/arthur/extend-workflow-s…
lanwen Jan 14, 2016
1adb56c
[maven-release-plugin] prepare release github-1.16.0
Jan 14, 2016
a244a4a
[maven-release-plugin] prepare for next development iteration
Jan 14, 2016
57aa480
Update checkstyle-config.xml
KostyaSha Jan 19, 2016
5bd034e
Merge pull request #107 from jenkinsci/KostyaSha-patch-1
lanwen Jan 19, 2016
bda9cc0
[FIXES JENKINS-24690] Administrative monitor to show hook registering…
lanwen Jan 17, 2016
c0b718e
Merge pull request #106 from lanwen/hook_monitor
lanwen Jan 26, 2016
c925a45
[maven-release-plugin] prepare release github-1.17.0
Jan 26, 2016
5664ab1
[maven-release-plugin] prepare for next development iteration
Jan 26, 2016
24759ab
Fixed incorrect proxy configuration of GitHubLoginFunction
schulzh Jan 28, 2016
c43344a
Merge pull request #109 from schulzh/master
lanwen Jan 28, 2016
590bd09
Handle ssh:// URLs that doesn't contain git@
kad Feb 19, 2016
1087b7b
GitHubRepositoryNameTest: add ssh:// URL schema tests
kad Feb 19, 2016
d49f0cb
Merge pull request #110 from kad/flex-ssh-urls
lanwen Feb 19, 2016
baed375
[maven-release-plugin] prepare release github-1.17.1
Feb 22, 2016
3875c8e
[maven-release-plugin] prepare for next development iteration
Feb 22, 2016
20c159e
Fix the license in pom.xml
oleg-nenashev Feb 23, 2016
1dcd22c
Title is too long and extra wording is not adding useful information
kohsuke Mar 8, 2016
dc33199
Nobody cares what plugin is being configured!
kohsuke Mar 8, 2016
096e911
It's no longer just updating commit status and hooks
kohsuke Mar 8, 2016
198d6c3
Long text is not useful here
kohsuke Mar 8, 2016
f2a02a4
optionalBlock that just has one field feels pointless
kohsuke Mar 8, 2016
d4a13b3
Sensible order is endpoint,credentials, then other stuff
kohsuke Mar 8, 2016
fac0f8f
It's not just credentials we are testing
kohsuke Mar 8, 2016
bbcdc95
Everything here is clearly configuration, so this is redundant
kohsuke Mar 8, 2016
de4f7a3
validate button can only work with fields that are defined before, no…
kohsuke Mar 8, 2016
96c8426
Help text updates
kohsuke Mar 8, 2016
aade2d4
Obviously everything here is configuration
kohsuke Mar 8, 2016
48c754f
Removing these methods as requested in PR #112
kohsuke Mar 8, 2016
c990995
Mentioning megabytes as per requested in #112
kohsuke Mar 8, 2016
633ce4e
Trying to make the reviewer happy
kohsuke Mar 8, 2016
2e31640
Unused imports
kohsuke Mar 8, 2016
89ac151
Don't let the build fail if the commit doesn't exist in upstream
kohsuke Mar 7, 2016
ddef520
Using the 'marked' revision that works better with merge commits
kohsuke Mar 8, 2016
44a8781
Merge pull request #112 from jenkinsci/config-improvements
lanwen Mar 10, 2016
159934f
prevent JS in link to github
lanwen Mar 15, 2016
12aaa78
add logging for url cleanup and more tests with links
lanwen Mar 16, 2016
b61b10d
Merge pull request #114 from lanwen/xss
lanwen Mar 17, 2016
c779355
[maven-release-plugin] prepare release github-1.18.0
Mar 17, 2016
38c7691
[maven-release-plugin] prepare for next development iteration
Mar 17, 2016
a93e9c8
revert setter for custom api url (bool) in GitHubServerConfig as of i…
lanwen Mar 17, 2016
6d52a76
Merge pull request #115 from lanwen/setter_revert
lanwen Mar 17, 2016
f147d85
[maven-release-plugin] prepare release github-1.18.1
Mar 17, 2016
9c980d6
[maven-release-plugin] prepare for next development iteration
Mar 17, 2016
0719dc7
Use new-styled parent pom for plugins
lanwen Mar 12, 2016
c60f558
turn off concurrency for tests
lanwen Apr 2, 2016
a33285a
clean some sections in pom already listed in parent
lanwen Apr 2, 2016
4cf308e
Merge pull request #113 from lanwen/plugin-pom
lanwen Apr 2, 2016
e1728e4
change logger in commit notifier, reformat code in tests for notifiers
lanwen Apr 9, 2016
25d7939
Merge pull request #111 from jenkinsci/failed-update
lanwen Apr 9, 2016
7ab3480
replace license and wiki with badges in readme
lanwen Apr 9, 2016
978bc72
Merge pull request #117 from jenkinsci/badges_in_readme
lanwen Apr 9, 2016
5c15cb0
Fix typos - s/mailformed/malformed
logikal Mar 18, 2016
3e92bac
Merge pull request #118 from lanwen/pr_116
lanwen Apr 9, 2016
25372c7
[maven-release-plugin] prepare release github-1.18.2
Apr 9, 2016
28d8dec
[maven-release-plugin] prepare for next development iteration
Apr 9, 2016
4a08364
extended setter for status
lanwen Apr 17, 2016
11c3ba0
changing status error handler
lanwen Apr 21, 2016
fc067ba
conditional result setter
lanwen Apr 22, 2016
7ac6bc3
manually entered context and sha sources
lanwen Apr 22, 2016
a991b41
javadocs and helps for new status setter
lanwen Apr 24, 2016
040d31c
tests for new status setter
lanwen Apr 24, 2016
66917ef
reuse new status step code in old classes
lanwen Apr 24, 2016
350802c
Merge pull request #119 from lanwen/st_setter
lanwen Apr 26, 2016
2b2b1b9
Improved logging format.
jglick Apr 28, 2016
7a16460
I buy a 3k screen so that Checkstyle can complain I am using more tha…
jglick Apr 28, 2016
e8af197
Merge pull request #120 from jglick/GitHubPushTrigger-logging
lanwen Apr 28, 2016
3f9b6ef
[maven-release-plugin] prepare release github-1.19.0
May 1, 2016
e713bfb
[maven-release-plugin] prepare for next development iteration
May 1, 2016
e595e9a
Minor grammatical fix
jinjorge May 3, 2016
4211c28
Merge pull request #121 from jinjorge/patch-1
KostyaSha May 3, 2016
7682bf3
Minor grammatical fix to error messages (#122)
jinjorge May 3, 2016
d4af6be
Updated okhttp. (#123)
KostyaSha May 4, 2016
d9af402
use tagname without artifact prefix for releases (#124)
lanwen May 8, 2016
bf050c1
[maven-release-plugin] prepare release v1.19.1
May 12, 2016
19420c0
[maven-release-plugin] prepare for next development iteration
May 12, 2016
3b8aaee
[FIXED JENKINS-36144] Borrow the SCMTrigger's queue (or fall back to …
stephenc Jun 22, 2016
105ee8f
[JENKINS-36144] Ooops need a guard when we can borrow
stephenc Jun 22, 2016
05b895f
[JENKINS-36144] After careful analysis of some of the code paths, saf…
stephenc Jun 22, 2016
3c81c4d
[JENKINS-36144] Align with code conventions
stephenc Jun 22, 2016
3fd5cfe
[JENKINS-36144] More verbose function name
stephenc Jun 22, 2016
dddd6bc
[JENKINS-36144] Code review catches bugs... who'd have thunk it
stephenc Jun 22, 2016
10e991e
Merge pull request #126 from stephenc/jenkins-36144
lanwen Jun 24, 2016
4007938
[maven-release-plugin] prepare release v1.19.2
Jun 24, 2016
e9caf00
[maven-release-plugin] prepare for next development iteration
Jun 24, 2016
ca75bde
[JENKINS-36445] Show first 7 characters of SHA1 in change log hyperli…
MarkEWaite Jul 11, 2016
dfd8f97
[maven-release-plugin] prepare release v1.19.3
Jul 20, 2016
300ee68
[maven-release-plugin] prepare for next development iteration
Jul 20, 2016
f6c4832
Create NOTICE.md (#130)
lanwen Jul 20, 2016
4ae71ca
Manually entered repository source
Vlatombe Jul 21, 2016
0e620aa
Add missing newlines
Vlatombe Jul 21, 2016
1adbffc
Create codecov.yml
lanwen Jul 21, 2016
1dfca4d
Use printf for logging
Vlatombe Jul 21, 2016
330cdbe
Add a test when url isn't valid (repository name is null)
Vlatombe Jul 21, 2016
6b10f5a
Merge pull request #131 from Vlatombe/manually_entered_repository_source
lanwen Jul 21, 2016
9649beb
add some override annotations in ghcommitnotifier
lanwen Jul 21, 2016
6fdefd9
Merge pull request #132 from jenkinsci/lanwen-patch-1
lanwen Jul 21, 2016
c01ce0b
[maven-release-plugin] prepare release v1.20.0
Jul 24, 2016
5c8af54
[maven-release-plugin] prepare for next development iteration
Jul 24, 2016
b6683ee
[JENKINS-33974] Payload verification using shared secrets
martinmine Jul 1, 2016
70117b9
Use OOP power to calculate sign, add integration test
lanwen Aug 11, 2016
0f90fe7
Merge pull request #134 from lanwen/hook_secrets
lanwen Aug 12, 2016
01ba06c
[maven-release-plugin] prepare release v1.21.0
Aug 15, 2016
8262d62
[maven-release-plugin] prepare for next development iteration
Aug 15, 2016
05ad7b4
[JENKINS-37481] Ignore sign header if sign not defined in Jenkins
lanwen Aug 18, 2016
1ffc7ce
Merge pull request #136 from lanwen/ignore_hook_not_defined
lanwen Aug 19, 2016
ef4f66d
[maven-release-plugin] prepare release v1.21.1
Aug 19, 2016
c7927b4
[maven-release-plugin] prepare for next development iteration
Aug 19, 2016
c0fbee2
Allow to bann a pusher to avoid triggering loop when your job is push…
ouaibsky Sep 7, 2015
83cb0cb
rebase and fix CR
ouaibsky Aug 20, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# From https://github.com/Danimoth/gitattributes/blob/master/Java.gitattributes
# Handle line endings automatically for files detected as text
# and leave all files detected as binary untouched.
* text=auto

#
# The above will handle all files NOT found below
#
# These files are text and should be normalized (Convert crlf => lf)
*.css text
*.df text
*.htm text
*.html text
*.java text
*.js text
*.json text
*.jsp text
*.jspf text
*.properties text
*.sh text
*.svg text
*.tld text
*.txt text
*.xml text

# These files are binary and should be left untouched
# (binary is a macro for -text -diff)
*.class binary
*.dll binary
*.ear binary
*.gif binary
*.ico binary
*.jar binary
*.jpg binary
*.jpeg binary
*.png binary
*.so binary
*.war binary
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ target
*.ipr
*.iws
.idea/

# autogenerated resources
src/main/webapp/css/*
136 changes: 136 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,136 @@
# Functional contribution

We are welcome for any contribution. But every new feature implemented in this plugin should:

- Be useful enough for lot of people (should not cover only your professional case)
- Should not break existing use cases and should avoid breaking the backward compatibility in existing APIs.
- If the compatibility break is required, it should be well justified.
[Guide](https://wiki.eclipse.org/Evolving_Java-based_APIs_2)
and [jenkins solutions](https://wiki.jenkins-ci.org/display/JENKINS/Hint+on+retaining+backward+compatibility) can help to retain the backward compatibility
- Should be easily maintained (so maintainers need some time to think about architecture of implementation)
- Have at least one test for positive use case

This plugin is used by lot of people, so it should be stable enough. Please ensure your change is compatible at least with the last LTS line.
Any core dependency upgrade must be justified

# Code Style Guidelines

Most of rules is checked with help of the *maven-checkstyle-plugin* during the `validate` phase.
Checkstyle rules are more important than this document.

## Resulting from long experience

* To the largest extent possible, all fields shall be private. Use an IDE to generate the getters and setters.
* If a class has more than one `volatile` member field, it is probable that there are subtle race conditions. Please consider where appropriate encapsulation of the multiple fields into an immutable value object replace the multiple `volatile` member fields with a single `volatile` reference to the value object (or perhaps better yet an `AtomicReference` to allow for `compareAndSet` - if compare-and-set logic is appropriate).
* If it is `Serializable` it shall have a `serialVersionUID` field. Unless code has shipped to users, the initial value of the `serialVersionUID` field shall be `1L`.

## Indentation

1. **Use spaces.** Tabs are banned.
2. **Java blocks are 4 spaces.** JavaScript blocks as for Java. **XML nesting is 4 spaces**

## Field Naming Conventions

1. "hungarian"-style notation is banned (i.e. instance variable names preceded by an 'm', etc)
2. If the field is `static final` then it shall be named in `ALL_CAPS_WITH_UNDERSCORES`.
3. Start variable names with a lowercase letter and use camelCase rather than under_scores.
4. Spelling and abreviations: If the word is widely used in the JVM runtime, stick with the spelling/abreviation in the JVM runtime, e.g. `color` over `colour`, `sync` over `synch`, `async` over `asynch`, etc.
5. It is acceptable to use `i`, `j`, `k` for loop indices and iterators. If you need more than three, you are likely doing something wrong and as such you shall either use full descriptive names or refactor.
6. It is acceptable to use `e` for the exception in a `try...catch` block.
7. You shall never use `l` (i.e. lower case `L`) as a variable name.

## Line Length

To the greatest extent possible, please wrap lines to ensure that they do not exceed 120 characters.

## Maven POM file layout

* The `pom.xml` file shall use the sequencing of elements as defined by the `mvn tidy:pom` command (after any indenting fix-up).
* If you are introducing a property to the `pom.xml` the property must be used in at least two distinct places in the model or a comment justifying the use of a property shall be provided.
* If the `<plugin>` is in the groupId `org.apache.maven.plugins` you shall omit the `<groupId>`.
* All `<plugin>` entries shall have an explicit version defined unless inherited from the parent.

## Java code style

### Imports

* For code in `src/main`:
- `*` imports are banned.
- `static` imports are preferred until not mislead.
* For code in `src/test`:
- `*` imports of anything other than JUnit classes and Hamcrest matchers are banned.

### Annotation placement

* Annotations on classes, interfaces, annotations, enums, methods, fields and local variables shall be on the lines immediately preceding the line where modifier(s) (e.g. `public` / `protected` / `private` / `final`, etc) would be appropriate.
* Annotations on method arguments shall, to the largest extent possible, be on the same line as the method argument (and, if present, before the `final` modifier)

### Javadoc

* Each class shall have a Javadoc comment.
* Unless the method is `private`, it shall have a Javadoc comment.
* Getters and Setters shall have a Javadoc comment. The following is prefered
```
/**
* The count of widgets
*/
private int widgetCount;

/**
* Returns the count of widgets.
*
* @return the count of widgets.
*/
public int getWidgetCount() {
return widgetCount;
}

/**
* Sets the count of widgets.
*
* @param widgetCount the count of widgets.
*/
public void setWidgetCount(int widgetCount) {
this.widgetCount = widgetCount;
}
```
* When adding a new class / interface / etc, it shall have a `@since` doc comment. The version shall be `FIXME` (or `TODO`) to indicate that the person merging the change should replace the `FIXME` with the next release version number. The fields and methods within a class/interface (but not nested classes) will be assumed to have the `@since` annotation of their class/interface unless a different `@since` annotation is present.

### IDE Configuration

* Eclipse, by and large the IDE defaults are acceptable with the following changes:
- Tab policy to `Spaces only`
- Indent statements within `switch` body
- Maximum line width `120`
- Line wrapping, ensure all to `wrap where necessary`
- Organize imports alphabetically, no grouping
* NetBeans, by and large the IDE defaults are acceptable with the following changes:
- Tabs and Indents
+ Change Right Margin to `120`
+ Indent case statements in switch
- Wrapping
+ Change all the `Never` values to `If Long`
+ Select the checkbox for Wrap After Assignement Operators
* IntelliJ, by and large the IDE defaults are acceptable with the following changes:
- Wrapping and Braces
+ Change `Do not wrap` to `Wrap if long`
+ Change `Do not force` to `Always`
- Javadoc
+ Disable generating `<p/>` on empty lines
- Imports
+ Class count to use import with '*': `9999`
+ Names count to use static import with '*': `99999`
+ Import Layout
* import all other imports
* blank line
* import static all other imports

## Issues

This project uses [Jenkins Jira issue tracker](https://issues.jenkins-ci.org)
with [github-plugin](https://issues.jenkins-ci.org/browse/JENKINS/component/15896) component.

## Links

- https://wiki.jenkins-ci.org/display/JENKINS/contributing
- https://wiki.jenkins-ci.org/display/JENKINS/Extend+Jenkins
4 changes: 4 additions & 0 deletions NOTICE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## License notes

This plugin uses part of Guava's code in class named `org.jenkinsci.plugins.github.util.FluentIterableWrapper`
licensed under **Apache 2.0** license
34 changes: 5 additions & 29 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
Jenkins Github Plugin
=====================
=====================

[![Coverage](https://img.shields.io/sonar/http/sonar.lanwen.ru/com.coravy.hudson.plugins.github:github/coverage.svg?style=flat)](http://sonar.lanwen.ru/dashboard/index?id=com.coravy.hudson.plugins.github:github)
[![License](https://img.shields.io/github/license/jenkinsci/github-plugin.svg)](LICENSE)
[![wiki](https://img.shields.io/badge/GitHub%20Plugin-WIKI-blue.svg?style=flat)](http://wiki.jenkins-ci.org/display/JENKINS/Github+Plugin)

Read more: [http://wiki.jenkins-ci.org/display/JENKINS/Github+Plugin](http://wiki.jenkins-ci.org/display/JENKINS/Github+Plugin)

Development
===========
Expand Down Expand Up @@ -46,30 +49,3 @@ Plugin releases
---------------

mvn release:prepare release:perform -Dusername=juretta -Dpassword=******


License
-------

(The MIT License)

Copyright (c) 2009 Stefan Saasen

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
'Software'), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
2 changes: 2 additions & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
codecov:
token: 9f11e1c0-2bd1-48d1-910e-24f8cf20cc4f
Loading