-
Notifications
You must be signed in to change notification settings - Fork 402
Migrate tests to JUnit Jupiter #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests to JUnit Jupiter #387
Conversation
That's why junit5 was not used. What is the goal at all of doing this? |
As I wrote its not available yet, but will be once jenkinsci/jenkins-test-harness#900 is being delivered via a newer
In general I'd say it's a good practice to not rely on outdated libraries - even for testing. This PR removes one of these outdated libraries ( |
84830a1 to
b447f83
Compare
* Migrate annotations and imports * Migrate assertions * Migrate GHMock Rule to Extension * Migrate to DataProviderRunner to ParameterizedTest * Remove public visibility for test classes and methods * Minor clean up
e46fdea to
e6bd25b
Compare
|
@jenkinsci/github-plugin-developers Kindly requesting a review. |
# Conflicts: # src/test/java/com/cloudbees/jenkins/GlobalConfigSubmitTest.java
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup * Ban JUnit4 imports
|
just merge it? |
No objections from my end. Since tests pass, coverage is the same and no other check is failing it's pretty safe to assume the migration is successful. I will anyway stick around and am happy to take care of any issues that may result out of merging. |
This PR aims to migrate all tests to JUnit Jupiter. Changes include:
RuletoExtensionDataProviderRunnertoParameterizedTestI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.