Skip to content

feat: Switch to ionicons-api #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NotMyFault wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Switch to ionicons-api #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>github-api</artifactId>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>ionicons-api</artifactId>
<version>19.v744f3b_2b_b_e4e</version>
</dependency>

<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/coravy/hudson/plugins/github/GithubLinkAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public String getDisplayName() {

@Override
public String getIconFileName() {
return "symbol-logo-github plugin-github";
return "symbol-logo-github plugin-ionicons-api";
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jenkinsci/plugins/github/admin/GitHubHookRegisterProblemMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ public static class GitHubHookRegisterProblemManagementLink extends ManagementLi
public String getIconFileName() {
return monitor.getProblems().isEmpty() && monitor.ignored.isEmpty()
? null
: "symbol-logo-github plugin-github";
: "symbol-logo-github plugin-ionicons-api";
}

@Override
Expand Down
1 change: 0 additions & 1 deletion src/main/resources/images/symbols/logo-github.svg
View file
Open in desktop

This file was deleted.