-
Notifications
You must be signed in to change notification settings - Fork 131
[JENKINS-76185] Add GitLab merge request compatibility #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9c7781b to
6619583
Compare
|
@MarkEWaite Thanks for picking this up 👍 |
|
I will be on vacation for 2 weeks and won't look further at this until after I return. The plugin needs better documentation to show how to use pull requests as a parameter. If you can help with that documentation and can confirm that it works, that would be great. |
|
Hi @MarkEWaite, I just tested this feature and added the documentation for a Gitlab merge request example. It worked as expected. |
|
@MarkEWaite I think this is ready for review or merge. Let me know if something else needs to be done. |
Thanks! It will likely be several more weeks before I can review it. Many other things are on my list. |
As mentions in JENKINS-76185, I want to make it possible to use this plugin with Gitlab Merge Requests as well.
I would like to know if I missed something somewhere, as I am not yet familiar with this code base.
Testing done
I tested it by running all the tests by
mvn test.Did not yet test it manually.
Submitter checklist