Improved LAUNCH_DIAGNOSTICS behavior#561
Draft
jglick wants to merge 3 commits into
Draft
Conversation
This was referenced May 28, 2026
(cherry picked from commit bd611bf)
jglick
added a commit
to jglick/kubernetes-plugin
that referenced
this pull request
May 29, 2026
… getting `KubernetesPipelineTest#runInPodWithDifferentShell` to pass requires jenkinsci/durable-task-plugin#561 (see jenkinsci#871).
jtnord
reviewed
May 29, 2026
| long currentTimestamp = getLogFile(workspace).lastModified(); | ||
| if (currentTimestamp == 0) { | ||
| listener.getLogger().println("process apparently never started in " + controlDir); | ||
| if (!LAUNCH_DIAGNOSTICS) { |
Member
There was a problem hiding this comment.
why was this change from the LAUNCH_DIAGNOSTIC field?
the change means that termination diagnostics will always reflect the latest change of the property, yet the launching diagnostics does not and requires a restart (or setting via the script console).
Member
Author
There was a problem hiding this comment.
This is part of another class, and I did not wish to introduce a new serialized boolean field. Since this clause should rarely be encountered, and usually the property would be set at startup, this seemed close enough.
Member
Author
|
I need to verify whether the |
jtnord
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on jenkinsci/kubernetes-plugin#2837 I rediscovered jenkinsci/kubernetes-plugin#871 (comment). Simplifying the launcher behavior when this flag is set, to actually check the wrapper status and log output normally. It is possible we could just make this behavior unconditional (only calling
quiet(true)normally) but that would require more careful testing.