Skip to content

Drop third-party payload builders#1126

Open
jchambers wants to merge 2 commits into
mainfrom
jon/drop_third_party_payload_builders
Open

Drop third-party payload builders#1126
jchambers wants to merge 2 commits into
mainfrom
jon/drop_third_party_payload_builders

Conversation

@jchambers
Copy link
Copy Markdown
Owner

The Jackson and GSON payload builders really don't produce very much value, and certainly not much relative to their maintenance burden. This change discards third-party payload builders as Pushy modules, but adds payload builder methods so callers can serialize payloads using the tool(s) of their choice.

For example, what was previously done with a dedicated payload builder subclass can now be done with something like:

final ObjectMapper objectMapper = new ObjectMapper();

final String payload = new ApnsPayloadBuilder()
    .setAlertBody("Example!")
    .build(objetMapper::writeValueAsString);

Ultimately, this should give end users more flexibility and also make Pushy easier to maintain.

@jchambers jchambers added this to the v0.16.0 milestone May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant