Skip to content

Conversation

@pehala
Copy link

@pehala pehala commented Jan 28, 2019

  • Added Build and BuildConfig classes for their respective objects.
  • Changed handling of not empty stderr in oc_command.
    • Now it will not fail if return code is successful but stderr is not empty, it will instead just throw a warning.
    • Reasoning: Starting build from a local directory will write upload progress to stderr but will still succeed.
  • Added option to pass *args to execute method of OpenshiftKind.
    • Reasoning: start-build command needs the name of the build.
  • Switched order of *args and **opts when executing a command.
    • Reasoning: start-build needs name of the build as a first argument.
  • Added option to pass type to update of OpenshiftKind.
    • Reasoning: Executing command like this one:
      • oc patch dc/system-app -p '[{"op": "add", "path": "/spec/strategy/rollingParams/pre/execNewPod/env/-", "value": {"name": "ORACLE_SYSTEM_PASSWORD", "value": "<<<<SYSTEM_PASSWORD>>>>"}}]' --type=json

- Add support for JSON Patch updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant