fix: backlog bug fixes and improvements #4697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove testnet/mainnet toggle from protocol activity feed - Move event title (action label) to its own line above amount
- Display correct currency symbol (ETH/USD) in Rulesets tab issuance rates - Convert ETH payments to USD value for token calculation on USD-based projects
- Add QueueSafeDeployErc20TxsModal for Safe-owned projects - Detect Safe ownership and route to Safe modal instead of Relayr - Queue deployERC20For transactions to Safe for each chain
- Add isLoading to ProjectMetadataContext - Pass loading state from metadata providers (v1, v2v3, v4v5) - Show loading spinner in V4V5ProjectDashboard while metadata loads
- Use useV4V5WalletHasPermission for NFT tab and button visibility - Remove dev environment bypass from permission hook - Show NFT tab when user has permission to add NFTs (owner/Safe signer/operator) - Show Add NFT button only for users with actual permission
Add burnEvent to IGNORED_EVENTS to prevent duplicate entries when users cash out. Only manualBurnEvent (true manual burns) will now appear in activity feeds.
Display fee as "$NANA fee" with link to Bananapus project (ID 1) in Send Payouts activity. Links to correct version (v4/v5) and chain based on the event's project context.
Display 'None' when project has zero total supply and zero ruleset weight, indicating no tokens exist and none will be issued.
- Add estimateOmnichainGas utility with 20% buffer and silent fallback - Replace hardcoded gas * chainCount with dynamic estimation per chain - Consolidate fallback gas values in OMNICHAIN_GAS_FALLBACKS constant - Add omnichain support to ArchiveProjectSettingsPage
V5 was not explicitly handled in buildJB721TierParams, causing it to fall through to V3.2 params. The sort then failed when accessing undefined contributionFloor property. Added V5 to use V4 params and implemented runtime type detection for bigint vs BigNumber comparison.
Use selectedChainBalance instead of wallet.balance to show the user's balance on the project's deployment chain rather than the wallet's default chain.
Fixes incorrect ETH received calculation on non-context chains (e.g., Optimism) by ensuring totalSupply and nativeTokenSurplus are fetched from the user's selected chain rather than the context chain.
- Replace "Redeeming tokens" text with "Cashing out tokens" - Use orange pendulum loading image instead of generic spinner
…suance rate, and cash out tax rate - Change strict equality (=== null) to loose equality (== null) to handle both null and undefined values from useJBUpcomingRuleset - Rewrite startTimeDatum to use pairToDatum pattern with proper loading state checks
Replace tabs with unified cycle navigator for browsing current, upcoming, and historical rulesets. Add navigation arrows and dropdown for direct cycle selection with status badges and date ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
browsing current, upcoming, and past rulesets