Preparing MediaSendViewModel for compose #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (selected == null) { | ||
| selected = LinkedList() | ||
| } | ||
| val selected: MutableList<Media> = selectedMediaOrDefault.toMutableList() |
There was a problem hiding this comment.
Is that the same logic with selectedMediaOrDefault as opposed to the previous selectedMedia.value?
Are they updated and managed the same?
You seem to use _uiState.value.selectedMedia in parts and selectedMediaOrDefault in others, so just need to make sure it's all needed or their differences
Owner
Author
There was a problem hiding this comment.
Yup it is the same. I also updated parts that use _uiState.value.selectedMedia to use selectedMediaOrDefault (now selectedMedia) with source of truth coming from the UiState.
ThomasSession
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the viewmodel (and some UI implementation) to use Flow.
Legacy LiveData bridges are kept as to not break or have minimal changes in the UI while refactor is in progress.