Attempt to fix the memory leak mentioned in #691#775
Open
carmeli-tamir wants to merge 1 commit intojbeder:masterfrom
Open
Attempt to fix the memory leak mentioned in #691#775carmeli-tamir wants to merge 1 commit intojbeder:masterfrom
carmeli-tamir wants to merge 1 commit intojbeder:masterfrom
Conversation
SGSSGene
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #691
It seems that tests pass and the issue described in 691 doesn't reproduce.
The fix simply doesn't assign the argument node's memory to the changed node's memory. I don't see a reason to do it, although I'm not very familiar with the internals of YAML.
It makes sense that the changed node would like to keep the argument node's memory, but not vice-versa.