Skip to content

Conversation

@jbcoe
Copy link
Owner

@jbcoe jbcoe commented Nov 6, 2025

No description provided.

@jbcoe jbcoe requested a review from Copilot November 6, 2025 02:33

This comment was marked as outdated.

@nbx8 nbx8 marked this pull request as ready for review November 6, 2025 02:36
@nbx8 nbx8 requested review from Twon and nbx8 as code owners November 6, 2025 02:36
@nbx8 nbx8 marked this pull request as draft November 6, 2025 02:37
Copy link

@zhihaoy zhihaoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, but none of these matters. Deleting it, putting std::indirect with operator T& in the type traits in this file, and everything works as before, because neither type is exposed in the interface. It's the saved effort of modeling operations via meta-programming matters.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.71%. Comparing base (cea96af) to head (bae0c36).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exploration/recursive_variant_test.cc 76.00% 6 Missing ⚠️
exploration/recursive_variant.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   99.51%   98.71%   -0.81%     
==========================================
  Files          12       14       +2     
  Lines         829      855      +26     
  Branches       90       90              
==========================================
+ Hits          825      844      +19     
- Misses          4       11       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jbcoe jbcoe requested a review from zhihaoy November 7, 2025 01:22
Copy link
Collaborator

@nbx8 nbx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appendix is a nice addition, thanks.

@jbcoe jbcoe requested a review from Copilot November 7, 2025 02:10

This comment was marked as outdated.

Copy link
Contributor

Copilot AI commented Nov 7, 2025

@jbcoe I've opened a new pull request, #612, to work on those changes. Once the pull request is ready, I'll request review from you.

@jbcoe jbcoe marked this pull request as ready for review November 7, 2025 02:37
Add CMake configuration for recursive_variant_test

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@jbcoe jbcoe changed the title Add Appendix listing code from National Body comment author Add appendix discussing recursive variants Nov 7, 2025
@jbcoe jbcoe merged commit bf01966 into main Nov 7, 2025
32 of 34 checks passed
@jbcoe jbcoe deleted the kona-2025-Nov-05-appendix branch November 7, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants