-
Notifications
You must be signed in to change notification settings - Fork 15
Add appendix discussing recursive variants #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zhihaoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, but none of these matters. Deleting it, putting std::indirect with operator T& in the type traits in this file, and everything works as before, because neither type is exposed in the interface. It's the saved effort of modeling operations via meta-programming matters.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 99.51% 98.71% -0.81%
==========================================
Files 12 14 +2
Lines 829 855 +26
Branches 90 90
==========================================
+ Hits 825 844 +19
- Misses 4 11 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nbx8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appendix is a nice addition, thanks.
Add CMake configuration for recursive_variant_test Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
No description provided.