feat: migration to fastify-fusion framework #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive migration plan for moving mockhttp to use fastify-fusion, which consolidates 7 dependencies into a single package with sensible defaults. Key points: - Remove 7 dependencies: @fastify/helmet, @fastify/rate-limit, @fastify/static, @fastify/swagger, @fastify/swagger-ui, pino, pino-pretty - Add fastify-fusion as replacement - Keep 6 dependencies: @fastify/cookie, @scalar/api-reference, detect-port, fastify, hookified, html-escaper - Gain CORS and caching features as opt-in extras - Detailed step-by-step migration instructions included
Replace manual Fastify plugin registration with fastify-fusion's fuse() function, consolidating common plugins and reducing dependency count. Changes: - Add fastify-fusion for helmet, rate-limit, static, and logging - Remove fastify-config.ts (logging now handled by fastify-fusion) - Simplify swagger.ts to export only the description - Update mock-http.ts to use fuse() for plugin registration - Keep @fastify/swagger and @fastify/swagger-ui for custom Scalar UI Dependencies removed (handled by fastify-fusion): - @fastify/helmet - @fastify/rate-limit - pino - pino-pretty All 346 tests pass with 100% function/line coverage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
===========================================
- Coverage 100.00% 99.63% -0.37%
===========================================
Files 41 40 -1
Lines 1108 1105 -3
Branches 194 198 +4
===========================================
- Hits 1108 1101 -7
- Misses 0 2 +2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cover the helmet: false branch in fastify-fusion configuration.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8933a1ff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tion Fastify logging must be enabled when creating the instance - it cannot be enabled afterward. Move logging configuration from fuse() options back to Fastify() constructor to restore observability.
Remove @fastify/swagger and @fastify/swagger-ui dependencies - now handled by fastify-fusion's openApi option. Configure docsRoutePath to "/docs/ui" to avoid conflict with custom Scalar homepage at "/". Dependencies now handled by fastify-fusion: - @fastify/helmet - @fastify/rate-limit - @fastify/swagger - @fastify/swagger-ui - pino / pino-pretty Net reduction: 6 dependencies removed, 1 added (fastify-fusion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat: migration to fastify-fusion framework