-
Notifications
You must be signed in to change notification settings - Fork 2
feat: implement httpbin Dynamic Data endpoints #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add support for all Dynamic Data endpoints matching httpbin.org: - /uuid - Returns a UUID4 - /bytes/:n - Returns n random bytes with optional seed - /stream-bytes/:n - Streams n random bytes in chunks - /delay/:n - Delays response for up to 10 seconds - /base64/:value - Decodes base64url-encoded string - /stream/:n - Streams up to 100 JSON responses - /range/:n - Returns n bytes with HTTP Range support - /drip - Drips data over duration after optional delay - /links/:n/:offset - Generates HTML page with n links Includes comprehensive test coverage for all endpoints.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 32 41 +9
Lines 847 1108 +261
Branches 147 194 +47
==========================================
+ Hits 847 1108 +261 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add test for invalid base64 data validation - Add test for invalid delay parameter in drip endpoint - Add test for initial delay in drip endpoint - Add test for invalid seed in stream-bytes endpoint - Add test for duration parameter in range endpoint - Fix base64 route to properly validate base64 input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65109dff28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add coverage ignore comments for defensive fallback code paths that are difficult to trigger in tests (host/query defaults, invalid NaN checks on already-validated input).
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 484ffc8218
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add length validation to base64 route - length mod 4 cannot be 1 as it cannot represent valid encoded data. This prevents values like /base64/Z from returning 200 with empty body.
Add support for all Dynamic Data endpoints matching httpbin.org:
Includes comprehensive test coverage for all endpoints.