[codex] Add jelly demos and improve JellySwitch performance#19
Open
jamesrochabrun wants to merge 17 commits into
Open
[codex] Add jelly demos and improve JellySwitch performance#19jamesrochabrun wants to merge 17 commits into
jamesrochabrun wants to merge 17 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jroch-cardsbranch context needed by the demo target, includingMotionManager, the metal avatar/cosmic card demo work, and JellySlider.Why
The JellySwitch optimization depends on the active branch context rather than bare
main: the demo target onmainwas missing support files such asMotionManager, so the narrower PR did not represent the branch that actually compiled locally. This PR now carries the full work fromjroch-cardsplus the JellySwitch performance commit.Validation
swift buildpasses.xcodebuild -project ShaderKitDemo.xcodeproj -scheme ShaderKitDemo -destination 'generic/platform=iOS Simulator' buildpasses.git diff --check origin/main..HEADpasses.swift testcurrently fails on an existing version assertion:ShaderKit.versionis2.0.0, whileShaderKitTests.swiftexpects1.0.0.