Add subscribeTo method in order to track additional eventStreams#11
Open
kryptt wants to merge 10 commits intojamesmacaulay:masterfrom
Open
Add subscribeTo method in order to track additional eventStreams#11kryptt wants to merge 10 commits intojamesmacaulay:masterfrom
kryptt wants to merge 10 commits intojamesmacaulay:masterfrom
Conversation
… unsubscribed from when the component unmounts
kryptt
force-pushed
the
master
branch
2 times, most recently
from
125036f to
6adbc41
Compare
eventStream, domEventStream and valueStream in terms of a common eventBus function.
kryptt
force-pushed
the
master
branch
7 times, most recently
from
2ccb476 to
ff87b91
Compare
propsProperty -> streamProps rename stateProperty -> streamState rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a component's will mount event it is possible to subcribe to additional event streams that need to be cleaned on once the component unmounts. A method like (subscribeTo) allows for these types of situations to be considered.