Fix for failing component unmount test#10
Open
wolfflow wants to merge 1 commit intojamesmacaulay:masterfrom
Open
Fix for failing component unmount test#10wolfflow wants to merge 1 commit intojamesmacaulay:masterfrom
wolfflow wants to merge 1 commit intojamesmacaulay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test failure detected while running jasmine specs with latest Bacon.js (0.7.30)
Testing jasmine specs via PhantomJS
BaconMixin
#eventStream
- returns the stream for that defined name......√
- returns always the same event stream......√
- defines a function property with the name of the stream......√
- that defined function can be used as event handler, and pushes to the stream......√
- removes subscribers when the component unmounts......×
TypeError: 'undefined' is not a function (evaluating 'stream.hasSubscribers()') in /project/node_modules/react-bacon/tmp/specs.js (line 22246) (1)