fix: guard SharedWorker reference on runtimes without the global#11
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
`SharedWorker` is not defined on mobile Safari, in-app WebViews, and hardened browser modes. The bare `guest instanceof SharedWorker` checks in `host.connect()` throw `ReferenceError` on those runtimes before we even reach the iframe-target codepath, which is what most consumers actually need. Adds an `isSharedWorker(guest)` helper that gates the `instanceof` check with `typeof SharedWorker !== "undefined"`, mirroring the existing `isWorkerLike` pattern for `Worker`. Use it at both `host.ts` call sites.
baransu
force-pushed
the
tomasz/guard-sharedworker-reference
branch
from
99236ea to
a77a8a3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedWorkeris not defined on mobile Safari, in-app WebViews, and hardened browser modes. The bareguest instanceof SharedWorkerchecks inhost.connect()(lines 53 and 61 ofsrc/host.ts) throwReferenceErroron those runtimes — before we even reach the iframe-target codepath, which is what most consumers actually need.Adds an
isSharedWorker(guest)helper that gates theinstanceofcheck withtypeof SharedWorker !== "undefined", mirroring the existingisWorkerLikepattern forWorker. Uses it at bothhost.tscall sites.Test plan
npm run build— cleannpm test— all green, including 2 new regression tests:isSharedWorkerreturns false without throwing whenSharedWorkeris undefined; detects instances when the global is present