Fix assignment recovery with multiple tabs#222
Open
mscotch1 wants to merge 1 commit intojaltekruse:masterfrom
Open
Fix assignment recovery with multiple tabs#222mscotch1 wants to merge 1 commit intojaltekruse:masterfrom
mscotch1 wants to merge 1 commit intojaltekruse:masterfrom
Conversation
Error stemmed from `localStorage` item being removed in one tab, but the other tab still attempted to load it. Now, there is consistent error checking for a missing item when loading from `localStorage`. Recovery items were added to the component's state (as they are used in the rendering process); on failure, recovery items are retrieved from `localStorage` again so they are up-to-date and user can try loading most recent assignment again.
Contributor
Author
|
Fixes #214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error stemmed from
localStorageitem being removed in one tab, but the other tab still attempted to load it. Now, there is consistent error checking for a missing item when loading fromlocalStorage.Recovery items were added to the component's state (as they are used in the rendering process); on failure, recovery items are retrieved from
localStorageagain so they are up-to-date and user can try loading most recent assignment again.