Skip to content

Sourcery Starbot ⭐ refactored jakemongaya/sphinx-tutorial #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SourceryAI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sourcery Starbot ⭐ refactored jakemongaya/sphinx-tutorial #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions crawler/src/crawler/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@ class Crawler(object):
def __init__(self, url, delay, ignore):
self.url = url
self.delay = delay
if ignore:
self.ignore = ignore.split(',')
else:
self.ignore = []
self.ignore = ignore.split(',') if ignore else []
Copy link
Author

@SourceryAI SourceryAI Jul 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Crawler.__init__ refactored with the following changes:


def get(self, url):
"""
Expand All @@ -59,10 +56,7 @@ def crawl(self):
for tag in soup.findAll('a', href=True):
link = tag['href']
parsed = urlparse(link)
if parsed.scheme:
to_get = link
else:
to_get = self.url + link
to_get = link if parsed.scheme else self.url + link
Comment on lines -62 to +59
Copy link
Author

@SourceryAI SourceryAI Jul 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Crawler.crawl refactored with the following changes:

if should_ignore(self.ignore, to_get):
print('Ignoring URL: {url}'.format(url=to_get))
continue
Expand Down
5 changes: 1 addition & 4 deletions crawler/src/crawler/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ def log(url, status):
:param status: A status code for the `Response`.

"""
if 200 <= int(status) < 300:
prose = 'OK'
else:
prose = 'ERR'
prose = 'OK' if 200 <= int(status) < 300 else 'ERR'
Copy link
Author

@SourceryAI SourceryAI Jul 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function log refactored with the following changes:

print("{prose}: {status} {url}".format(prose=prose, url=url, status=status))


Expand Down