fix: okhttp4 resource path rename and unpin hardcoded okhttp version#26
Open
zeitlinger wants to merge 1 commit intojack-berg:okhttp-sender-major-versionsfrom
Open
Conversation
…ersion - generateMainResources was missing eachFile path rename, causing version.properties to land at the wrong package path in the jar - testing-internal hardcoded okhttp 5.3.2; let dependencyManagement own it Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for open-telemetry#8086.
Changes
exporters/sender/okhttp4/build.gradle.kts:generateMainResourceswas missing aneachFilepath rename. Without it,version.propertieslands atio/opentelemetry/exporter/sender/okhttp/internal/version.propertiesinside the okhttp4 jar (wrong package path). The jar listing in the PR confirms both paths are present. Added the sameeachFilerename thatgenerateMainSourcesandgenerateTestSourcesalready have.exporters/otlp/testing-internal/build.gradle.kts: Reverts the explicitokhttp:5.3.2pin —dependencyManagementalready manages the project-wide okhttp5 version, so this hardcode will drift on version bumps.