Include all runtime dependencies in examples dist#2744
Merged
riccardobl merged 1 commit intojMonkeyEngine:masterfrom May 8, 2026
Merged
Include all runtime dependencies in examples dist#2744riccardobl merged 1 commit intojMonkeyEngine:masterfrom
riccardobl merged 1 commit intojMonkeyEngine:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the jme3-examples/build.gradle file to use runtimeClasspath instead of compileClasspath when generating the JAR manifest's Class-Path and when copying dependencies for the dist task. This ensures that all necessary runtime dependencies are correctly included in the distribution. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix https://hub.jmonkeyengine.org/t/jme-3-10-0-alpha4/49585/3