Ogre deprecation j3o format - Example#2726
Ogre deprecation j3o format - Example#2726NwosuTy wants to merge 1 commit intojMonkeyEngine:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various asset loading paths in the jMonkeyEngine examples to use the .j3o format instead of the deprecated OgreXML (.mesh.xml, .scene) formats. Additionally, it adds deprecation notices and annotations to the Ogre-related classes and packages to encourage migration to modern formats like glTF. I have no further feedback to provide.
|
@riccardobl I know where the problem is and would fix and send, in the mean time the main.scene/j3o file I asked of is throwing bull errors in some scenes I was asking for its location but it seems that's fine for you |
|
The main.scene is loaded from a zip file via http, you can see the code here: that's from the very old jme repo on google code, if you want to convert it, I can rehost it somewhere else, but not an hard requirement for this PR as it is going to be a bit painful to debug |
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
NwosuTy
changed the title
|
@riccardobl i am done, you could proceed with a manual test, thank you |
|
Thanks! I'll start reviewing this shortly. |
|
Sure whenever you are done and if you are satisfied with the results please inform, so I could try and apply for the bounty fee |
|
Also if you want to fix the main.scene problem, I dont mind having a go at it next month, do enjoy the learning process. |
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Looks good so far! I am still halfway through the testing, will continue later.
I've found only one single broken example so far, that is reported in this review.
|
Resolved all 3 Reviews raised @riccardobl |
| Node rootNode = ((SimpleApplication)app).getRootNode(); | ||
| Camera cam = app.getCamera(); | ||
| Spatial ogreModel = assetManager.loadModel("Models/Oto/Oto.mesh.xml"); | ||
| Spatial ogreModel = assetManager.loadModel("Models/Oto/Oto.j3o"); |
There was a problem hiding this comment.
this is actually testing the ogre format itself, so it should not be modified by this PR, this means also the Oto model should be kept in the asset folder
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Every test works now!
There are only two issues left:
- you've changed TestOgreConvert to use j3o, but that test is specifically made for the ogre loader, so this change should be reverted
- you deprecation notice says
See <a href="https://jmonkeyengine.org/docs/3.6/manual/upgrading_to_glTF/">glTF migration guide</a>everywhere, but that link was hallucinated by the llm, it does not exist.
|
there are also 3 more examples that were not converted:
|
|
For the broken scene, I initially had to re-cobvert the scene as it seemed the conversion was happening before lights were loaded Then on the java file in the project, I switched fro. Getting world Light to get local light And alright I'd fix the current reviews mentioned and make another commit |
|
Also do you have an actual link I should revert too, or i just remove the link entirely |
i don't think we have a page for that, just remove the link |
Done both @riccardobl |
riccardobl
force-pushed
the
Ogre-Deprecation-J3o-Format
branch
from
9999e3a to
12ec523
Compare
Co-authored-by: Riccardo Balbo <os@rblb.it>
riccardobl
force-pushed
the
Ogre-Deprecation-J3o-Format
branch
from
12ec523 to
9335e10
Compare
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Thanks!
I made some final touches and restored the ogre files (even if we don't need them anymore, i figured they could still be used by third party code).
Also if you want to fix the main.scene problem, I dont mind having a go at it next month, do enjoy the learning process.
Yeah, these two zip files basically need the same conversion you did here, the only difference is that you would have to submit the zip as attachment to the PR so that I can host it somewhere. And for testing you would need to temporarily switch the locator to ZipLocator instead of HttpZipLocator to load it locally (or just use a local http server to serve it).
If you want to submit a follow up pr for this, feel free.
Regarding this PR, it is complete and mergeable now.
You can claim the bounty by submitting an expense of type "invoice" to our bounty program via our opencollective organization page, let me know when you do that, so I can approve it on my side.
Yeah I'd like take on the issue, where do I submit the follow up Then for this PR, thank you very much I'd create the invoice now, I do hope a wise ACH transfer is possible |
|
Expense-295902-jmonkeyengine-invoice-2026-05-04.pdf |
Approved. You'll receive the payout once our fiscal host confirms it
besides bounties, this project is open to receive any kind of pr. So you can just submit it, no need to have an issue attached. |
Okay then, can i get the zip file, or is it already in the project file |
|
you can find the zip urls in the relevant examples, where the asset locator is configured |
|
Alright then, also please could you re-approve the invoice, I had to specify the payment method address to not cause confusion |
|
done 👍 |
2 participants
Tagged The Ogre Loader as Deprecated
Converted all Models and Scenes used in Examples to .j3o files, and then switched all deprecated ogre files loading paths to the new .j3o files except where specified needed for ogre loading testing, deleted all unused ogre files
Note: could not find the main.scene file for conversion in scenes such as the TestAspectFov, TestMultiplesFilters etc
closes #2667