Skip to content

consider the insetForSection for estimating size #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andymedvedev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

consider the insetForSection for estimating size #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion IVCollectionKit/Source/CollectionSection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ open class CollectionSection : AbstractCollectionSection {
}

open func sizeForItem(at indexPath: IndexPath, boundingSize: CGSize) -> CGSize {
return items[indexPath.item].estimatedSize(boundingSize: boundingSize)
let sizeWithInsets = CGSize(width: boundingSize.width - insetForSection.left - insetForSection.right,
Copy link
Owner

@ivedeneev ivedeneev Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't totally agree with this change. For instance, we might not wanna use vertical insets for CollectionView with vertical scrolling. For some cases we need to know exact size of collection view and only use horizontal / vertical section insets for proportions calculation. I made change in 1.0.0 branch where we can respect section insets and spacings in cell size calculation. If u wanna match ur cell width to collectionView width and section insets u should consider use adjustsWidth(true) modifier of CollectionItem

Copy link
Owner

@ivedeneev ivedeneev Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see this example https://github.com/ivedeneev/CollectionKit/blob/master/Examples/ViewController.swift line 29

height: boundingSize.height - insetForSection.top - insetForSection.bottom)
return items[indexPath.item].estimatedSize(boundingSize: sizeWithInsets)
}

open func itemAdjustsWidth(at index: Int) -> Bool {
Expand Down