feat: Server library cleanup on paper install#4046
feat: Server library cleanup on paper install#4046harrisonablack wants to merge 2 commits intoitzg:masterfrom
Conversation
Defaults to true, do we want this or default to false?
…ERVER_LIBRARIES Split direct call to mc-image-helper on custom paper url to append --clean-libraries flag
|
One thing of note, i found the warn on "Failed to read installed libraries" when initially installing noisy and unnecessary I realised however a check can be performed if the manifest exists from a previous install. That way the warn can be removed, which isn't really helpfull. |
Yep, I was wondering about some of these scenarios. Yes, a PR to address that first would be great. I hadn't yet cut a release for Purpur library cleaning, so that can be included at same time. |
The way you have it, true by default makes sense to me. Then setting it to false can be a way to mitigate any unexpected behavior.
I like the non-specific variable name you introduced since it can be utilized across server types. As such, yeah that misc options area seems good. |
|
Adds support for itzg/mc-image-helper#748
Adds flag
$CLEAN_SERVER_LIBRARIESwhich defaults to true. When set appends--clean-librariesto mc-image-helper call.master already sets
MC_HELPER_VERSION=1.57.2> minimum 1.57.1 for the feature.Two questions, do you want the feature true or false by default? And should documentation be added iteratively on each jar type support, or done at the end? if iteratively, added under Misc Options or would you suggest a better location?