Челаев Петр Лаб. 1 Группа 6512#14
Open
PripyatskyPrometheus wants to merge 11 commits intoitsecd:mainfrom
Open
Conversation
github-actions
bot
added
In progress
Gwymlas
requested changes
Feb 26, 2026
ProgramProject.AppHost/AppHost.cs
Outdated
| @@ -0,0 +1,15 @@ | |||
| var builder = DistributedApplication.CreateBuilder(args); | |||
|
|
|||
| var cache = builder.AddRedis("cache"); | |||
There was a problem hiding this comment.
К редису добавить контейнер с вебмордой
ProgramProject.AppHost/AppHost.cs
Outdated
| .WithReference(cache) | ||
| .WaitFor(cache); | ||
|
|
||
| // ������� ������� |
ProgramProject.AppHost/AppHost.cs
Outdated
| // ������� ������� | ||
| var client = builder.AddProject<Projects.Client_Wasm>("client-wasm") | ||
| .WithExternalHttpEndpoints() | ||
| .WithReference(generationService); |
There was a problem hiding this comment.
Точно надо .WithReference(generationService)?
Я бы добавил .WaitFor(generationService)
Comment on lines
20
to
21
| <PackageReference Include="Aspire.Hosting.AppHost" Version="13.1.1" /> | ||
| <PackageReference Include="Aspire.Hosting.Redis" Version="13.1.1" /> |
Author
There was a problem hiding this comment.
Извините, вот этого замечания не понял? Какие пакеты версии разные? Наоборот они вроде одни и те же
There was a problem hiding this comment.
Выше в этом файле
<Sdk Name="Aspire.AppHost.Sdk" Version="9.3.1" />
Давай остановимся на версии 9.5.2
| <ItemGroup> | ||
| <ProjectReference Include="..\Client.Wasm\Client.Wasm.csproj" /> | ||
| <ProjectReference Include="..\ProgramProject.GenerationService\ProgramProject.GenerationService.csproj" /> | ||
| <ProjectReference Include="..\ProgramProject.ServiceDefaults\ProgramProject.ServiceDefaults.csproj" /> |
Comment on lines
26
to
27
| var uri = new Uri(origin); | ||
| return uri.Host == "localhost"; |
| var uri = new Uri(origin); | ||
| return uri.Host == "localhost"; | ||
| }) | ||
| .AllowAnyMethod() |
Comment on lines
19
to
25
| f.PickRandom(new[] | ||
| { | ||
| f.Commerce.ProductName() + " " + f.Hacker.Abbreviation(), | ||
| "Project " + f.Hacker.Noun(), | ||
| f.Finance.AccountName() + " System", | ||
| f.Lorem.Word() + "-" + f.Lorem.Word() | ||
| })) |
There was a problem hiding this comment.
f.PickRandom(
f.Commerce.ProductName() + " " + f.Hacker.Abbreviation(),
"Project " + f.Hacker.Noun(),
f.Finance.AccountName() + " System",
f.Lorem.Word() + "-" + f.Lorem.Word()
))
Comment on lines
15
to
18
| /// <summary> | ||
| /// Название проекта: комбинация из Commerce, Hacker, Finance, Lorem | ||
| /// </summary> | ||
| .RuleFor(p => p.Name, f => |
There was a problem hiding this comment.
Тут и в других местах используй по необходимости однострочные комментарии (//) для пояснения логики кода
XML-комментарии используй для документирования классов и методов, а не внутренней реализации
Comment on lines
87
to
93
| .FinishWith((f, p) => | ||
| { | ||
| if (p.ActualEndDate.HasValue) | ||
| { | ||
| p.CompletionPercentage = 100; | ||
| } | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ФИО: Челаев Петр
Номер группы: 6512
Номер лабораторной: 1
Номер варианта: 35
Краткое описание предметной области: Программный проект
Краткое описание добавленных фич: Добавлен сервис генерации и кэширование