feat: prefix registered icon identifier with extension key#23
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates auto-generated TYPO3 icon identifiers to include an extension-specific prefix to reduce collisions with other extensions’ icons.
Changes:
- Prefixes identifiers generated by
IconRegistrationUtility::convertFilenameToIdentifier()withtx-flexiblepages-.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/itplusx/flexible_pages/sessions/7511981e-e239-492b-8fda-de016c6398bd Co-authored-by: schloram <13196174+schloram@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icon identifiers auto-generated by
IconRegistrationUtility::convertFilenameToIdentifier()lacked an extension-specific prefix, risking collisions with icons from other extensions. The prefix was also hardcoded, drifting risk from the actual extension key.Changes
convertFilenameToIdentifier()now declaresstring $filenameOrPath): string— PHPDoc updated to matchExtensionConfigurationUtility::EXTKEYat runtime instead of hardcoded'tx-flexiblepages-':IconConfigurationTestandIconSetConfigurationTestfrom'icon-111'to'tx-flexiblepages-icon-111'