Apply suggestions for http dir from ai code review#839
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a set of hardening fixes across the HTTP server stack, primarily improving correctness for CORS responses, proxy error handling/timeouts, static file range handling, and multipart form file saving.
Changes:
- Add
Vary: Originbehavior to CORS responses when reflecting a non-wildcard Origin. - Harden static file Range handling (return 416 for invalid ranges) and fix proxy timeout application to the upstream connection.
- Add error handling for short writes when saving multipart form uploads to disk.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| http/server/HttpMiddleware.cpp | Updates CORS middleware to cache the Origin header value and add Vary: Origin when reflecting Origin. |
| http/server/HttpHandler.cpp | Adds invalid Range handling (416), switches forbidden proxy paths to immediate status responses, and applies proxy timeouts to upstream_io. |
| http/HttpMessage.h | Checks for short writes when persisting multipart form file content and returns 500 on failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yundi339
pushed a commit
to Yundi339/libhv
that referenced
this pull request
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.