Fix main_ctx_init: remove premature dir creation, increase MAX_PATH, add config file fallback#806
Draft
Fix main_ctx_init: remove premature dir creation, increase MAX_PATH, add config file fallback#806
Conversation
…add config fallback 1. Increase MAX_PATH from 260 to 1024 to handle longer file paths 2. Remove premature hv_mkdir(logdir) and hlog_set_file() calls from main_ctx_init to avoid creating directories before user customization 3. Add config file path fallback: run_dir/etc/prog.conf -> run_dir/prog.conf -> /usr/local/etc/prog.conf -> /etc/prog.conf (Unix only for last two) Co-authored-by: ithewei <26049660+ithewei@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with main_ctx_init function directory handling
Fix main_ctx_init: remove premature dir creation, increase MAX_PATH, add config file fallback
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main_ctx_initeagerly creates alogs/directory and sets the log file before callers can customize paths. Config file lookup is also hardcoded to a single location.hv_mkdir(logdir)andhlog_set_file()frommain_ctx_init. Callers can now customizeg_main_ctx.logfilebefore the log directory is created.run_dir/etc/:run_dir/etc/{program}.confrun_dir/{program}.conf/usr/local/etc/{program}.conf(Unix)/etc/{program}.conf(Unix)run_dir/etc/{program}.confif none foundOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.