Add new focus trap controller#1198
Merged
brentswisher merged 6 commits intodevelopfrom Mar 25, 2026
Merged
Conversation
|
Contributor
size-limit report 📦
|
daneah
reviewed
Feb 20, 2026
brentswisher
force-pushed
the
feat/update-focus-trap-library
branch
from
a386e05 to
9c44f6a
Compare
brentswisher
force-pushed
the
feat/update-focus-trap-library
branch
from
6f20eed to
eb8c2b4
Compare
brentswisher
requested review from
jialin-he,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
daneah
reviewed
Mar 20, 2026
daneah
approved these changes
Mar 20, 2026
sirrah-tam
approved these changes
Mar 23, 2026
Contributor
sirrah-tam
left a comment
sirrah-tam
left a comment
There was a problem hiding this comment.
Tested with MacOS & VoiceOver (Chrome & Safari), Windows & NVDA/JAWS (Chromium Edge). Everything works as expected.
This replaces the previous focus-trap implementation. This allows us to remove the previous implementation that relied on a forked package we are struggling to keep maintained.
The new focus trap library focuses the first element by default when the trap is activated. This is not ideal for dropdowns, which should only focus the first element if the user has navigated to the dropdown using the keyboard.
brentswisher
force-pushed
the
feat/update-focus-trap-library
branch
from
eca9a2d to
d8d67c3
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Closes #777
How does this change work?
This replaces the previous focus-trap implementation, with a new focus trap controller that uses the more actively maintained https://github.com/focus-trap/focus-trap library. It allows us to remove the previous implementation that relied on a forked package we are struggling to keep maintained.
Additional context